Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract css rules and scripts into separate files. #38

Merged
merged 3 commits into from
Oct 2, 2015

Conversation

akuhn
Copy link
Contributor

@akuhn akuhn commented Oct 2, 2015

Follow-up work to #36

  • Extracted css rules and scripts into separate files.
  • Reformatted css and javascript files in widget folder.
  • Removed animations from visualizations.

Test plan

@mistercrunch
Copy link
Member

img

mistercrunch added a commit that referenced this pull request Oct 2, 2015
Extract css rules and scripts into separate files.
@mistercrunch mistercrunch merged commit 8e790fa into master Oct 2, 2015
@mistercrunch mistercrunch deleted the px_javascript_css_files_2 branch October 2, 2015 06:15
hughhhh referenced this pull request in lyft/incubator-superset Apr 1, 2018
Salt files are failing on installing FE build, this change points to the upstream dir in the container

@lyft/command-center @amalakar @mistercrunch
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Apr 5, 2018
…-4761

[druid] Excluding refreshing verbose name (apache#4761)
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
feat: Add @superset-ui/time-format 

* update unit test (+6 squashed commits)
Squashed commits:
[5fae1ed] fix lint
[7672544] support local and utc
[c33fae7] update unit tests
[97fdc0d] fix all unit tests
[88e8029] add formatter code
[a33c76c] initialize

* update readme

* add formatDate and formatDateVerbose equivalent

* add unit test

* extract constants

* get to 100 coverage

* update readme

* Update preview test

* explicitly disable magic number
zhaoyongjie pushed a commit that referenced this pull request Nov 24, 2021
feat: Add @superset-ui/time-format

* update unit test (+6 squashed commits)
Squashed commits:
[5fae1ed] fix lint
[7672544] support local and utc
[c33fae7] update unit tests
[97fdc0d] fix all unit tests
[88e8029] add formatter code
[a33c76c] initialize

* update readme

* add formatDate and formatDateVerbose equivalent

* add unit test

* extract constants

* get to 100 coverage

* update readme

* Update preview test

* explicitly disable magic number
zhaoyongjie pushed a commit that referenced this pull request Nov 25, 2021
feat: Add @superset-ui/time-format

* update unit test (+6 squashed commits)
Squashed commits:
[5fae1ed] fix lint
[7672544] support local and utc
[c33fae7] update unit tests
[97fdc0d] fix all unit tests
[88e8029] add formatter code
[a33c76c] initialize

* update readme

* add formatDate and formatDateVerbose equivalent

* add unit test

* extract constants

* get to 100 coverage

* update readme

* Update preview test

* explicitly disable magic number
zhaoyongjie pushed a commit that referenced this pull request Nov 26, 2021
feat: Add @superset-ui/time-format

* update unit test (+6 squashed commits)
Squashed commits:
[5fae1ed] fix lint
[7672544] support local and utc
[c33fae7] update unit tests
[97fdc0d] fix all unit tests
[88e8029] add formatter code
[a33c76c] initialize

* update readme

* add formatDate and formatDateVerbose equivalent

* add unit test

* extract constants

* get to 100 coverage

* update readme

* Update preview test

* explicitly disable magic number
zhaoyongjie pushed a commit that referenced this pull request Nov 30, 2021
* chore: add tags and description

* Update packages/superset-ui-legacy-preset-chart-deckgl/src/layers/Arc/index.js

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update packages/superset-ui-legacy-preset-chart-deckgl/src/layers/Hex/index.js

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update packages/superset-ui-legacy-preset-chart-deckgl/src/layers/Scatter/index.js

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Update packages/superset-ui-legacy-preset-chart-deckgl/src/layers/Screengrid/index.js

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.5.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants