ES5 setup file correction #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES5 configuration proposed originally basically doesn't work. We're requiring 'enzyme' as Enzyme, but using configure() method out of nowhere:
```js
var Enzyme = require('enzyme');
var Adapter = require('enzyme-adapter-react-16');
configure({ adapter: new Adapter() });
```
I derived my variant from the original ES6 versino and it works fine for me.
Need it specifically for the .babelrc ["env", { "modules": false }] case.
ljharb
approved these changes
Sep 28, 2017
Closed
This was referenced Oct 3, 2017
This was referenced Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES5 configuration proposed originally basically doesn't work.
We're requiring 'enzyme' as Enzyme, but using configure() method out of nowhere:
I derived my variant from the original ES6 version and it works fine for me:
Need it specifically for the .babelrc
["env", { "modules": false }]case.