Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isLazy and isMemo and waiting to update new version of react-is #2298

Closed
wants to merge 4 commits into from
Closed

Update isLazy and isMemo and waiting to update new version of react-is #2298

wants to merge 4 commits into from

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Nov 28, 2019

Fixed #2297

@lh0x00 lh0x00 mentioned this pull request Nov 28, 2019
Closed
13 tasks
@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 30, 2019

@ljharb do you think it's ok If it can't help us solve the problem, please tell me. my project downgraded to wait for the new version of enzyme :(

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 30, 2019

I think we should solve it differently and I've created it here #2300

@lh0x00 lh0x00 closed this Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-is@16.12.0 changed the behavior of isMemo function, which cause enzyme selector fail.
2 participants
@lh0x00 @ljharb