Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect peer dependency "eslint@^4.9.0" #1913

Closed
ghost opened this issue Sep 12, 2018 · 3 comments
Closed

incorrect peer dependency "eslint@^4.9.0" #1913

ghost opened this issue Sep 12, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 12, 2018

with

eslint-config-airbnb-base@12.1.0
eslint@5.5.0

currently installed, local pkg updates report

warning " > eslint-config-airbnb-base@12.1.0" has incorrect peer dependency "eslint@^4.9.0".
@ljharb
Copy link
Collaborator

ljharb commented Sep 12, 2018

That’s because those aren’t compatible. You’ll need to update the base config, or downgrade eslint.

@ghost
Copy link
Author

ghost commented Sep 12, 2018

@ljharb

Yep, that does the trick, of course.

What's odd is, I had originally installed

yarn add --dev eslint-config-airbnb-base@latest

with that I still have

yarn list | grep airbnb
	├─ eslint-config-airbnb-base@12.1.0

even after a typical

yarn upgrade
	...
	warning " > eslint-config-airbnb-base@12.1.0" has incorrect peer dependency "eslint@^4.9.0".
	...
yarn list | grep airbnb
	├─ eslint-config-airbnb-base@12.1.0

If however, I explicitly RE-exec the add,

yarn add --dev eslint-config-airbnb-base@latest
	...
	[4/4] Building fresh packages...
	success Saved lockfile.
	success Saved 4 new dependencies.
	info Direct dependencies
	└─ eslint-config-airbnb-base@13.1.0
	info All dependencies
	├─ eslint-config-airbnb-base@13.1.0
	├─ has-symbols@1.0.0
	├─ object.assign@4.1.0
	└─ object.entries@1.0.4
	Done in 9.35s.
yarn list | grep airbnb
	├─ eslint-config-airbnb-base@13.1.0

that takes care of the warning

which begs the question ... why isnt' the @latest spec tracking across upgrades?

@ljharb
Copy link
Collaborator

ljharb commented Sep 12, 2018

Yarn has a number of bugs around peer deps. I’d suggest using npm, and the install command in the readme.

@ljharb ljharb closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant