Support Python >= 3.6 #547
Conversation
|
✅ Build knowledge-repo 1.0.766 completed (commit 2e49facae3 by @naoyak) |
|
❌ Build knowledge-repo 1.0.767 failed (commit 889fc41d2e by @naoyak) |
|
✅ Build knowledge-repo 1.0.768 completed (commit caec885738 by @naoyak) |
|
✅ Build knowledge-repo 1.0.769 completed (commit 566fb150eb by @naoyak) |
|
✅ Build knowledge-repo 1.0.770 completed (commit 05bc6cc875 by @naoyak) |
|
✅ Build knowledge-repo 1.0.777 completed (commit 156523442b by @naoyak) |
|
✅ Build knowledge-repo 1.0.778 completed (commit 00fa310f8b by @naoyak) |
|
✅ Build knowledge-repo 1.0.779 completed (commit 4f93017003 by @naoyak) |
naoyak
force-pushed
the
update-ci
branch
2 times, most recently
from
5bb2631
to
a4c2a26
Compare
|
✅ Build knowledge-repo 1.0.800 completed (commit f73aded24d by @naoyak) |
|
✅ Build knowledge-repo 1.0.801 completed (commit b43e39c1e7 by @naoyak) |
|
✅ Build knowledge-repo 1.0.802 completed (commit 04ca2433e1 by @naoyak) |
|
✅ Build knowledge-repo 1.0.803 completed (commit 665872be1a by @naoyak) |
|
✅ Build knowledge-repo 1.0.805 completed (commit 6d7635c6c4 by @naoyak) |
|
✅ Build knowledge-repo 1.0.807 completed (commit 45fed5a46a by @naoyak) |
|
✅ Build knowledge-repo 1.0.808 completed (commit ccf7957dab by @naoyak) |
|
❌ Build knowledge-repo 1.0.809 failed (commit 088f7f448e by @naoyak) |
|
❌ Build knowledge-repo 1.0.810 failed (commit 3b93a6b9ee by @naoyak) |
|
❌ Build knowledge-repo 1.0.811 failed (commit 206b15ed3b by @naoyak) |
|
❌ Build knowledge-repo 1.0.812 failed (commit 7b47ca9e0a by @naoyak) |
|
✅ Build knowledge-repo 1.0.813 completed (commit 96277786bb by @naoyak) |
|
✅ Build knowledge-repo 1.0.814 completed (commit c594be0e9c by @naoyak) |
|
✅ Build knowledge-repo 1.0.815 completed (commit 4f3b342962 by @naoyak) |
|
@john-bodley or @serenajiang, would you mind taking a look at this? |
|
@naoyak I think there might be a lot of users using Python 2.7 on their own computers. If they try to add posts to the repo using the older version of the knowledge repo compatible with Python 2.7 do you think there could be compatability issues? |
|
@bulam personally I think it's reasonable to require Python 3 for those who want to use the latest version of KR, given that Python 2 has been EOL'd and most major libraries have dropped support. Perhaps it makes sense to ship this in a new major/minor release along with your styling revamp in #548? |
knowledge_repo/app/routes/debug.py
Outdated
| @@ -77,7 +77,7 @@ def show_views(): | |||
|
|
|||
| methods = ','.join(rule.methods) | |||
| url = url_for(rule.endpoint, **options) | |||
| line = urllib.unquote("{:50s} {:20s} {}".format(rule.endpoint, methods, url)) | |||
| line = urllib.parse.unquote("{:50s} {:20s} {}".format(rule.endpoint, methods, url)) | |||
There was a problem hiding this comment.
Maybe use the logic below in terms of importing this.
There was a problem hiding this comment.
@john-bodley sorry can you clarify? Would it be better to from urllib.parse import unquote at the top of the file?
There was a problem hiding this comment.
Ah I see what you were referring to. Best to keep consistent 👍
|
✅ Build knowledge-repo 1.0.816 completed (commit aeab224826 by @naoyak) |
|
✅ Build knowledge-repo 1.0.817 completed (commit 2a5a84271f by @naoyak) |
|
✅ Build knowledge-repo 1.0.818 completed (commit 05e08b5f7f by @naoyak) |
Description of changeset
Proposing dropping support for Python versions < 3.6 to reduce maintenance overhead and unlock some dependency upgrades (#300 (comment)).
Test Plan: