Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Round Corners for iOS #1523

Closed
jhughes696 opened this issue Feb 23, 2022 · 8 comments
Closed

Enhancement Request: Round Corners for iOS #1523

jhughes696 opened this issue Feb 23, 2022 · 8 comments

Comments

@jhughes696
Copy link

jhughes696 commented Feb 23, 2022

Currently "Round Corners" for bezier paths is supported on Lottie Web and Android, but not iOS. It would be great if it was supported on iOS as well.

It would be a huge enhancement from an animation perspective. Below is an animation test that illustrates the capabilities of Round Corners, when applied to a Bezier Path in After Effects ( json download link )

RoundedCorners_test
RoundedCorners_test_PathPreview

@calda
Copy link
Member

calda commented Feb 23, 2022

For future reference, an algorithm for applying a corner radius to a bezier path is implemented here for lottie-web and here for lottie-android. After porting this algorithm to Swift it should be reasonably straightforward to add this support.

@jhughes696
Copy link
Author

Hey there! Any new progress regarding this feature request? Thanks!

@calda
Copy link
Member

calda commented Jun 2, 2022

I don't currently have plans to work on this -- would be happy to review a PR from somebody in the community though!

@Rimesh
Copy link

Rimesh commented Oct 22, 2022

Provided link for LottieFiles json is not working.
permission

@jhughes696
Copy link
Author

jhughes696 commented Oct 24, 2022

@Rimesh I just updated the JSON Link so you can download it without permissions. Are you considering working on this feature request? If so that would be SUPER appreciated. :)

@calda
Copy link
Member

calda commented Nov 2, 2022

Implemented in #1795 -- thank you very much @johnny-duo!

@calda calda closed this as completed Nov 2, 2022
@calda
Copy link
Member

calda commented Nov 2, 2022

We'll include this change in Lottie 4.0, which we plan on releasing at the end of the month

@jhughes696
Copy link
Author

YES! Thanks so much @johnny-duo & @calda. This will be super helpful for animators and should theoretically allow us to reduce file size (less point data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants