Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for time stretch to PreCompLayer #1726

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Conversation

calda
Copy link
Member

@calda calda commented Aug 22, 2022

This PR updates the Core Animation rendering engine's PreCompLayer to support timeStretch, which was previously not respected. Fixes #1725.

Before After
Simulator Screen Shot - iPhone 8 - 2022-08-22 at 11 05 15 Simulator Screen Shot - iPhone 8 - 2022-08-22 at 11 04 43

@calda calda force-pushed the cal--pre-comp-time-stretch branch from e186552 to 9095442 Compare August 22, 2022 18:14
Copy link
Collaborator

@erichoracek erichoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably one the most interesting JSON field names I've seen 🕐

@calda calda enabled auto-merge (squash) August 22, 2022 18:54
@calda calda merged commit 477b364 into master Aug 22, 2022
@calda calda deleted the cal--pre-comp-time-stretch branch August 22, 2022 19:03
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Animation rendering engine doesn't respect precomp time stretch
2 participants