Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 0.64 rc-1 #708

Closed
lorenzoangelini opened this issue Nov 27, 2020 · 33 comments
Closed

React Native 0.64 rc-1 #708

lorenzoangelini opened this issue Nov 27, 2020 · 33 comments

Comments

@lorenzoangelini
Copy link

Description

I'm trying to use lottie on the new release candidate of react native (0.64 rc-1) with hermes enabled, and i encountered this problem.
Screenshot 2020-11-26 at 00 22 48

Steps to Reproduce

  1. npx react-native init RN64 --version 0.64.0-rc.1
  2. yarn add lottie-react-native
  3. yarn add lottie-ios@3.1.8
  4. cd ios && pod instal

Expected behavior:
I can build the app on xcode.

Actual behavior:
Screenshot 2020-11-26 at 00 22 48

Versions

"react": "17.0.1",
"react-native": "0.64.0-rc.1"
"lottie-ios": "3.1.8",
"lottie-react-native": "^3.5.0",

@rpavlovs
Copy link

Commenting out React imports in AnimationViewManagerModule.swift and ContainerView.swift fixed it for me.

Not sure what's happening here - gonna proceed with a patch-patch for now.

@lorenzoangelini
Copy link
Author

@emilioicai
Copy link
Member

Hey @lorenzoangelini did you try with Hermes disabled? I guess we need to update the dependency on React

@lorenzoangelini
Copy link
Author

Hi! @emilioicai, i tried with hermes enabled, if i disable it, it is seems works.

@meftunca
Copy link

I am currently using version 0.64.0-rc.2. There is no problem with Android, but due to the problem I have with ios, my application release time was delayed. Any solution about this problem?

@sergeymorkovkin
Copy link

Same here. Any clue?

@meftunca
Copy link

I am waiting for a solution too

@djMax
Copy link

djMax commented Feb 7, 2021

This is happening in rc3 as well. Commenting out the react import did work for me too, so I've used patch-package to do this automatically.

@mrousavy
Copy link
Contributor

mrousavy commented Feb 8, 2021

@rpavlovs where exactly did you comment out those lines? I'm still having this exact error, not sure how I can temporarily fix it...

@mrousavy
Copy link
Contributor

mrousavy commented Feb 8, 2021

Nevermind, found it. To everyone having the same problem, I created a fix for this - apply this patch using patch-package: https://gist.github.com/mrousavy/517a18fdabdc048bba238132047cb4b0.
Update: my PR got merged: #738

@damienherve
Copy link

RN 0.64.0 has been released now, and this problem is still present. Don't really like to patch libraries locally, any fix soon?

@mrousavy
Copy link
Contributor

I have created a PR for this here: #738

@ltcaosj
Copy link

ltcaosj commented Mar 13, 2021

Yeah, waiting for the PR merged. I am still using the patch now.

@emilioicai
Copy link
Member

@mrousavy PR was merged, thanks!

@meehol meehol mentioned this issue Apr 5, 2021
@meehol
Copy link

meehol commented Apr 6, 2021

PR merged and forgotten, is anyone gonna tag/release that?

@emilioicai
Copy link
Member

Yes, this release is a big one so I want to be on the safe side and make sure nothing goes wrong ;)

@meehol
Copy link

meehol commented Apr 6, 2021

Awesome, thanks @emilioicai !

@sayem314
Copy link

Not sure why this was closed without a release.

@emilioicai
Copy link
Member

@sayem314 the PR is merged so it should be closed. Releases follow a different path

@sayem314
Copy link

@emilioicai understandable but so many people are having issues with 0.64 and when they come here searching for issues they don't see them in search results which leads to confusion.

@pixelknitter
Copy link

This problem is resolved with release of React Native 0.64 and making sure you're on latest Lottie 3.5.0

@sayem314
Copy link

This problem is resolved with release of React Native 0.64 and making sure you're on latest Lottie 3.5.0

Lottie 3.5.0? Also, FYI Lottie doesn't work with 0.64, at least the npm version.

@emilioicai
Copy link
Member

v4.0.0 is just released. It contains three large changes:

  • Fix react-native 0.64 compatibility
  • Windows support [C#]
  • macOS Support (based on react-native-windows)

So I would really appreciate if you guys could help me testing it and creating any issues you might find.

@klokie
Copy link

klokie commented Apr 27, 2021

Thanks @emilioicai !
Now I'm seeing these new errors after upgrading lottie-ios from 3.1.6 to 3.2.0 and lottie-react-native from 3.3.2 to 3.5.0:

Build target lottie-ios of project Pods with configuration Debug

Now I'm seeing these new errors after upgrading `lottie-ios` from `3.1.6` to `3.2.0` and `lottie-react-native` from `3.3.2` to `3.5.0`:
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:607:19: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/iOS/AnimatedControl.swift:67:51: error: argument passed to call that takes no arguments
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:111:120: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:101:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:109:38: error: cannot find type 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:114:30: error: cannot find 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:16:50: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:162:30: error: cannot find 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:162:62: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:607:19: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/iOS/AnimatedControl.swift:67:51: error: argument passed to call that takes no arguments
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:111:120: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:101:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:109:38: error: cannot find type 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:114:30: error: cannot find 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:16:50: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:162:30: error: cannot find 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:162:62: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:113:29: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:101:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:607:19: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:624:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:633:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:641:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:111:120: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:818:26: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:28:10: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:43:10: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:60:12: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:64:12: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:64:28: error: 'nil' requires a contextual type
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:113:29: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:101:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:607:19: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:624:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:633:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:641:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:111:120: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:818:26: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:28:10: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:43:10: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:60:12: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:64:12: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationViewInitializers.swift:64:28: error: 'nil' requires a contextual type
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/Animation/AnimationView.swift:607:19: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Public/iOS/Compatibility/CompatibleAnimationView.swift:45:66: error: argument passed to call that takes no arguments
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:16:50: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/PreCompositionLayer.swift:21:22: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:40:32: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:53:86: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:56:29: error: no exact matches in call to initializer
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/AnimationContainer.swift:109:38: error: cannot find type 'LayerFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:49:18: error: cannot find type 'TextLayer' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:51:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/PreCompositionLayer.swift:21:22: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/Utility/CompositionLayersInitializer.swift:16:50: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/PreCompositionLayer.swift:61:30: error: extraneous argument label 'contentsOf:' in call
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:53:86: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:49:18: error: cannot find type 'TextLayer' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:51:21: error: cannot find type 'AnimationFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:82:25: error: cannot find 'DefaultFontProvider' in scope
/Users/me/Project/node_modules/lottie-ios/lottie-swift/src/Private/LayerContainers/CompLayers/TextCompositionLayer.swift:119:29: error: 'nil' requires a contextual type

(full error here)
I'm not really sure where to begin debugging this - any pointers?

@emilioicai
Copy link
Member

hmm, that's really weird. Could you try with lottie-react-native v4.0.0 and lottie-ios v3.1.8? I think that's the preferred combination at this stage

@sayem314
Copy link

The weirdest and dumbest thing is to paste really long logs in github issue comments. Please use third party paste service such as Ubuntu paster or github gist.

@klokie
Copy link

klokie commented Apr 27, 2021

got it @sayem314, just moved to a gist, sorry about the interruption.

@emilioicai downgrading to lottie-ios v3.1.8 fixed those new errors, much appreciated. I'm still seeing the original error that brought me here, which is #755 / #734

@emilioicai
Copy link
Member

@klokie that error should be fixed on lottie-react-native v4.0.0, could you give it a try?

@klokie
Copy link

klokie commented Apr 28, 2021

It works great!!
"lottie-ios": "3.1.8",
"lottie-react-native": "^4.0.2",
"react-native": "^0.64.0",

Did the trick! Thanks so much :)

@choipd
Copy link

choipd commented Jun 13, 2021

After upgrade to 4.0.2 I got the error Cannot find 'hexStringToColor' in scope

node_modules/lottie-react-native/src/ios/LottieReactNative/ContainerView.swift:129:67: 
Cannot find 'hexStringToColor' in scope

@cmjunior
Copy link

@choipd I'd have the same error as yours. I'd solved this following this.

Adding the library as they said. I don't know how to use the path solution, if you know please tell me.

@vaibsshukla
Copy link

It works great!!
"lottie-ios": "3.1.8",
"lottie-react-native": "^4.0.2",
"react-native": "0.63.4",

Did the trick! Thanks so much :)

This worked

@Justin9606
Copy link

after upgrading to "4.0.2" to this it worked for me
"lottie-react-native": "4.0.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests