Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koin viewmodels' injection #339

Open
kaganovych opened this issue Jan 10, 2020 · 2 comments
Open

Koin viewmodels' injection #339

kaganovych opened this issue Jan 10, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@kaganovych
Copy link

I want to use Koin's extension functions for viewmodels' injections. Is there a way not to write MvRxViewModelFactory and use all the advantages of Koin? It's not very convenient to manually inject all of the dependencies into viewmodel through Factory.

@dmytroreutov
Copy link

Facing same issue. Should be upvoted

@gpeal
Copy link
Collaborator

gpeal commented Jan 26, 2020

@Jorikua @dmytroreutov At Airbnb and Tonal, we use dagger so that is where we have put the most effort. There is a dagger sample module now. Feel free to take a look and see if you can adapt it for koin. Fair warning though, we will probably not have the time to investigate koin integration ourselves though.

However, if changes are necessary to make it work well, we might consider it depending on what is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants