Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serf Support #72

Closed
ahelal opened this issue Aug 3, 2015 · 4 comments
Closed

serf Support #72

ahelal opened this issue Aug 3, 2015 · 4 comments

Comments

@ahelal
Copy link

ahelal commented Aug 3, 2015

Hi,

We are using smartstack for over a year and we love it, But we use the getyourguide fork that uses serf. And then we forked that and using our or branch.

I would like to avoid this fork nightmare. Are you open for serf reporter PR ?

@jolynch
Copy link
Collaborator

jolynch commented Aug 3, 2015

Nerve supports custom reporters by automatically requiring modules by name. See https://github.com/airbnb/nerve/blob/master/lib/nerve/reporter.rb for how this works. All you've got to do is make your reporter available for require. We're working on adding the same pluggable interface to Synapse.

Is the fork more substantial than the reporter itself?

@ahelal
Copy link
Author

ahelal commented Aug 10, 2015

Thank you, I will try to move to the plugin model that seems as a better option

@ahelal ahelal closed this as completed Aug 10, 2015
@jolynch
Copy link
Collaborator

jolynch commented Aug 10, 2015

@ahelal, let me know if you have any issues with integration. I'm working on the Synapse support right now.

@igor47, do we want to create a howto guide for this?

@ahelal
Copy link
Author

ahelal commented Aug 11, 2015

@jolynch, I am currently on vacation. Will start working on that next week. I will dig in the code and raise issues as I go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants