Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time-picker #255

Open
brunocoelho opened this issue Jan 18, 2017 · 29 comments
Open

Support time-picker #255

brunocoelho opened this issue Jan 18, 2017 · 29 comments
Labels
feature request I want a new feature in react-dates!

Comments

@brunocoelho
Copy link

brunocoelho commented Jan 18, 2017

Hi guys, is there any possibility to also support time-picker in the future?

@brunocoelho brunocoelho changed the title Add time-picker Support time-picker Jan 18, 2017
@ljharb ljharb added the feature request I want a new feature in react-dates! label Mar 27, 2017
@oyeanuj
Copy link

oyeanuj commented May 19, 2017

@ljharb Just curious about your thoughts or plans on this request?

@ljharb
Copy link
Member

ljharb commented May 20, 2017

To be honest, this seems like a useful thing to be an entirely separate package; which if we wanted a DateTimePicker, we'd pull in as a dependency. react-dates is already pretty big.

@mateioprea
Copy link

Hello guys, I did this today: https://www.dropbox.com/s/6z0wu6papx6ff5m/Screenshot%202017-05-22%2018.58.15.png?dl=0

I'm still working on it, but will submit a pull requests when I finish :)

@oyeanuj
Copy link

oyeanuj commented May 22, 2017

@mateioprea Good job on making it feel part of the plugin, I'd love for this to be an option. One thing you might be missing is an AM/PM meridiem toggle?

@ljharb I hear you on the size, but I wonder if the more effective solution there is to be able to import only the component you need rather than importing the whole package with all the components in them? (for example, even today, when I am using SingleDatePicker, it ends up importing DateRangePicker in the final build)

@mateioprea
Copy link

@oyeanuj now that you're saying will work on implementing that too. I thought that 24h format will be fine, but I think AM/PM thing can be optional and it can default to 24h

@ljharb
Copy link
Member

ljharb commented May 22, 2017

@oyeanuj that's easily resolved by deep-linking to the thing you want, instead of importing from the "main" entry point - but bundle size isn't what i was talking about.

@bamaboy

This comment has been minimized.

@smeijer

This comment has been minimized.

@mateioprea

This comment has been minimized.

@oyeanuj

This comment has been minimized.

@mateioprea

This comment has been minimized.

@fengshuo

This comment has been minimized.

@email2vimalraj

This comment has been minimized.

@JarLowrey

This comment has been minimized.

@Hassan-Zahid

This comment has been minimized.

@react-dates react-dates deleted a comment from sahilchopra Dec 11, 2018
@lionskape

This comment has been minimized.

@ervinsr

This comment has been minimized.

@okcthulhu

This comment has been minimized.

@Shumaister

This comment has been minimized.

@fmaymone

This comment has been minimized.

@Sefton419

This comment has been minimized.

@jeffj
Copy link

jeffj commented Nov 9, 2019

My product (see attached screen shot) requires a time picker. If anyone is working on this and has a branch I would love to lend a hand.

download

@m-nathani

This comment has been minimized.

@dhanraj-khatal

This comment has been minimized.

@mehrdadg11

This comment has been minimized.

@Xapgkop4uk
Copy link

Unfortunately, react-dates doesn't work with time. I created a wrapper over DateTimePicker to fix it but faced hardcoded hours in sources. https://github.com/airbnb/react-dates/pull/2072/files there required changes. Please take a look. I will appreciate it

@caub

This comment has been minimized.

@cgarrovillo

This comment has been minimized.

@phtmgt

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request I want a new feature in react-dates!
Projects
None yet
Development

No branches or pull requests