-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support time-picker #255
Comments
@ljharb Just curious about your thoughts or plans on this request? |
To be honest, this seems like a useful thing to be an entirely separate package; which if we wanted a |
Hello guys, I did this today: https://www.dropbox.com/s/6z0wu6papx6ff5m/Screenshot%202017-05-22%2018.58.15.png?dl=0 I'm still working on it, but will submit a pull requests when I finish :) |
@mateioprea Good job on making it feel part of the plugin, I'd love for this to be an option. One thing you might be missing is an AM/PM meridiem toggle? @ljharb I hear you on the size, but I wonder if the more effective solution there is to be able to import only the component you need rather than importing the whole package with all the components in them? (for example, even today, when I am using |
@oyeanuj now that you're saying will work on implementing that too. I thought that 24h format will be fine, but I think AM/PM thing can be optional and it can default to 24h |
@oyeanuj that's easily resolved by deep-linking to the thing you want, instead of importing from the "main" entry point - but bundle size isn't what i was talking about. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unfortunately, react-dates doesn't work with time. I created a wrapper over DateTimePicker to fix it but faced hardcoded hours in sources. https://github.com/airbnb/react-dates/pull/2072/files there required changes. Please take a look. I will appreciate it |
Hi guys, is there any possibility to also support time-picker in the future?
The text was updated successfully, but these errors were encountered: