New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthetic event warning onKeyDown #514
Comments
I can confirm that modifying the source and setting the Either fix would be pretty simple so i could make a PR if someone could confirm which solution seems better. |
I just stumbled on this warning message in my codebase, and tracked it down to react-dates. Yes, wrapping and persisting the event is fully compatible with existing behavior. But I'd probably prefer the I'm not sure if anyone's reading your bug report and offer of help, so just submitting a PR and gathering feedback, is probably the best way to get your question answered. Are you interested in doing that @JemarJones , or should I? |
Fixes react-dates#514 , which happens due to Events being stored to be delivered on the trailing edge of a keyDown. I believe we don't need the trailing edge, and it is better than a persisted Event.
I'm not 100% sure it is related but I have the problem in 14.0.0 14.1.0 and 13.0.6 by simply pressing SHIFT+TAB to switch to the next field. I have a lot of fields on my page and I want to navigate to the next one. Nothing special in my code, I just inserted your component today with all the default parameters of the example. I tested on Firefox 56.
[edit]: I though it was TAB but it is actually shift+tab so it's probably more SHIFT |
@cecton Experiencing the same issue.
|
Fixes react-dates#514 , which happens due to Events being stored to be delivered on the trailing edge of a keyDown. I believe we don't need the trailing edge, and it is better than a persisted Event.
Fixes #514 , which happens due to Events being stored to be delivered on the trailing edge of a keyDown. I believe we don't need the trailing edge, and it is better than a persisted Event.
Fixes react-dates/react-dates#514 , which happens due to Events being stored to be delivered on the trailing edge of a keyDown. I believe we don't need the trailing edge, and it is better than a persisted Event.
Fixes react-dates/react-dates#514 , which happens due to Events being stored to be delivered on the trailing edge of a keyDown. I believe we don't need the trailing edge, and it is better than a persisted Event.
With the latest version of the daterangepicker i get the following warnings logged if i for example click into the start date input, type something and hit
cmd
+A
.I notice that you're throttling the
onKeyDown
event handler, so it may be that the event is nullified by the time the handler is actually called, as described here http://stackoverflow.com/questions/35435074/using-debouncer-with-react-event. This makes sense to me as the warning is being thrown on the trailing edge of the throttle.The text was updated successfully, but these errors were encountered: