Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for required property #142

Merged
merged 1 commit into from
Oct 23, 2016
Merged

Conversation

FezVrasta
Copy link

@FezVrasta FezVrasta commented Oct 22, 2016

Fixes #136.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Oct 22, 2016
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that the UX around HTML5 form validation can't be customized, so it's rarely advisable to enable it - but adding this is straightforward 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.043% when pulling ca6dc25 on FezVrasta:master into 5db44d2 on airbnb:master.

@FezVrasta
Copy link
Author

FezVrasta commented Oct 22, 2016

I think it's the exact opposite, I use it exactly because it's a standard across the whole browser, so the people don't have to learn a new pattern on each website.

Also, you can intercept the HTML5 validation event and replace it with whatever you want if you prefer.

@majapw majapw merged commit c180878 into react-dates:master Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants