New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the focus out event in IE11 #1524

Merged
merged 13 commits into from Feb 7, 2019

Conversation

Projects
None yet
6 participants
@marcos0x
Copy link
Contributor

marcos0x commented Feb 1, 2019

No description provided.

Marcos Avila
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2019

Coverage Status

Coverage decreased (-0.5%) to 84.504% when pulling afcd575 on marcos0x:fix/focus-out-event-ie11 into 7083d2a on airbnb:master.

@majapw majapw requested a review from monokrome Feb 4, 2019

@majapw

This comment has been minimized.

Copy link
Contributor

majapw commented Feb 4, 2019

Can we add context to the comment about this check?

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Feb 4, 2019

also surfacing #1524 (comment)

@monokrome
Copy link
Contributor

monokrome left a comment

Small request for changes, but looks good :) Thanks for contributing back to the project!

Show resolved Hide resolved src/components/DateRangePicker.jsx Outdated
@monokrome

This comment has been minimized.

Copy link
Contributor

monokrome commented Feb 4, 2019

@marcos0x Would you mind adding tests for this usecase?

marcos0x and others added some commits Feb 6, 2019

Marcos Avila
@marcos0x

This comment has been minimized.

Copy link
Contributor Author

marcos0x commented Feb 6, 2019

@monokrome It is tested in IE11 and works well

Marcos Avila and others added some commits Feb 6, 2019

Marcos Avila
@ljharb

ljharb approved these changes Feb 6, 2019

Copy link
Member

ljharb left a comment

Thanks, this looks great.

Show resolved Hide resolved src/components/DateRangePicker.jsx Outdated
Show resolved Hide resolved src/components/DateRangePicker.jsx

ljharb and others added some commits Feb 6, 2019

Update src/components/DateRangePicker.jsx
Co-Authored-By: marcos0x <marcos0x@gmail.com>
@marcos0x

This comment has been minimized.

Copy link
Contributor Author

marcos0x commented Feb 7, 2019

@monokrome Can you approve this?

@devans-k4

This comment has been minimized.

Copy link

devans-k4 commented Feb 7, 2019

Waiting on this as well. Thanks btw @marcos0x

@majapw majapw merged commit a7a7c46 into airbnb:master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.5%) to 84.504%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment