Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleDatePicker doesn't fire onDateChange in IE11 #1530

Closed
mccambridge opened this issue Feb 5, 2019 · 20 comments
Closed

SingleDatePicker doesn't fire onDateChange in IE11 #1530

mccambridge opened this issue Feb 5, 2019 · 20 comments
Assignees
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D

Comments

@mccambridge
Copy link

react-dates version
e.g. react-dates@18.4.1

Describe the bug
In, IE11, SingleDatePicker renders and opens on focus. But when I click on a date, the calendar disappears without updating the date in the input. This works fine on other browsers.

Desktop (please complete the following information):

  • OS: Windows
  • Browser IE
  • Version 11.0.9600.19236

Is the issue reproducible in Storybook?
https://airbnb.io/react-dates/?selectedKind=SingleDatePicker%20%28SDP%29&selectedStory=default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

@waldell
Copy link

waldell commented Feb 13, 2019

Any update on this? We're having the same issue and tried importing airbnb-browser-shims without success. Would be much appreciated if this could be fixed.

@majapw
Copy link
Collaborator

majapw commented Feb 13, 2019

This should be fixed in v19.0.3. Please let me know if that's not the case!

@majapw majapw closed this as completed Feb 13, 2019
@papscript
Copy link

I'm afraid it still doesn't work :<
Just tested on WM with windows 7 and ie11

  • OS: Windows 7
  • Browser IE
  • Version 11.0.9600.19266
  • react-dates@19.0.3

@waldell
Copy link

waldell commented Feb 15, 2019

It works using 19.0.3 in the DateRangePicker but the SingleDatePicker still does not work.

  • OS: Windows 10
  • Browser IE
  • Version 11.523.17134.0
  • react-dates@19.0.3

@ljharb ljharb reopened this Feb 15, 2019
@mccambridge
Copy link
Author

Confirmed still not working in IE for SDP default example on airbnb.io/react-dates

@austinwerner358
Copy link

I am seeing this issue on react-dates 19.0.3 (was also seeing it on 18.4.1).

  • OS: Windows 10 Enterprise x64
  • Browser: Internet Explorer 11
  • Browser Version: 11.2007.14393.0
  • react-dates@19.0.3

No javascript console errors.

On the same computer, it works on Chrome and Edge.

@EricBrovko
Copy link

Hi there!
The method onDateChange is not called on IE11 when user selects the date

@Laawe
Copy link

Laawe commented Mar 2, 2019

Having the same issue my version is ^20.0.0

@S1rFrancis
Copy link

I'm also seeing this issue in v20.0.0

@DaveCole
Copy link

DaveCole commented Mar 8, 2019

Actually it looks like the error started occurring when I updated from react-dates 18.1.0 to 18.1.1.

@Laawe
Copy link

Laawe commented Mar 11, 2019

So no update on this?

@rvanlaarhoven
Copy link

Actually it looks like the error started occurring when I updated from react-dates 18.1.0 to 18.1.1.

It's working fine for me on v18.3.1 & v18.4.0 and started to be an issue from v18.4.1.

@ljharb ljharb added bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D labels Mar 12, 2019
@majapw
Copy link
Collaborator

majapw commented Mar 12, 2019

I'll take a look today!

@DaveCole
Copy link

@rvanlaarhoven it might be possible I updated from 18.1.0 to 18.4.1 -- what's interesting is in order to roll back I also had to roll back the package-lock.json file; changing the version in package.json alone didn't make a difference. Maybe I just don't grasp the impact of package-lock.json well enough. Thanks @majapw!

@ljharb
Copy link
Member

ljharb commented Mar 12, 2019

Once this fix lands in master, I’ll backport it to v18 and v19 as well.

@Laawe
Copy link

Laawe commented Mar 13, 2019

Actually it looks like the error started occurring when I updated from react-dates 18.1.0 to 18.1.1.

It's working fine for me on v18.3.1 & v18.4.0 and started to be an issue from v18.4.1.

I've tried this versions and there's no response 😢

@GattoLupesco
Copy link

GattoLupesco commented Mar 13, 2019

Hi all,
the bug is the same founded for DateRangePicker in #1516 the solution is the same: in method "onFocusOut" of SingleDatePicker you have to change:
if (this.dayPickerContainer.contains(e.relatedTarget || e.target)) return;
into:
if (this.dayPickerContainer.contains(e.relatedTarget || e.target) || this.dayPickerContainer.contains(e.target)) return;

release the fix please... PR #1578

@wkgjr
Copy link

wkgjr commented Mar 27, 2019

Hello, any update on this?

ljharb pushed a commit to GattoLupesco/react-dates that referenced this issue Apr 7, 2019
ljharb added a commit that referenced this issue Apr 7, 2019
…_on_ie11

issue #1530 - Fix date selection in the SDP
@svvb
Copy link

svvb commented Jun 5, 2019

@ljharb @majapw the issue is still present. Currently using react-dates ^18.2.2 but upgrading to ^20.0.0 still didn't solve the problem.

@ljharb
Copy link
Member

ljharb commented Jun 5, 2019

@svvb it should be fixed in v20.2. if not, please file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests