-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleDatePicker doesn't fire onDateChange in IE11 #1530
Comments
Any update on this? We're having the same issue and tried importing |
This should be fixed in v19.0.3. Please let me know if that's not the case! |
I'm afraid it still doesn't work :<
|
It works using 19.0.3 in the DateRangePicker but the SingleDatePicker still does not work.
|
Confirmed still not working in IE for SDP default example on airbnb.io/react-dates |
I am seeing this issue on react-dates 19.0.3 (was also seeing it on 18.4.1).
No javascript console errors. On the same computer, it works on Chrome and Edge. |
Hi there! |
Having the same issue my version is ^20.0.0 |
I'm also seeing this issue in v20.0.0 |
Actually it looks like the error started occurring when I updated from react-dates 18.1.0 to 18.1.1. |
So no update on this? |
It's working fine for me on v18.3.1 & v18.4.0 and started to be an issue from v18.4.1. |
I'll take a look today! |
@rvanlaarhoven it might be possible I updated from 18.1.0 to 18.4.1 -- what's interesting is in order to roll back I also had to roll back the package-lock.json file; changing the version in package.json alone didn't make a difference. Maybe I just don't grasp the impact of package-lock.json well enough. Thanks @majapw! |
Once this fix lands in master, I’ll backport it to v18 and v19 as well. |
I've tried this versions and there's no response 😢 |
Hi all, release the fix please... PR #1578 |
Hello, any update on this? |
…_on_ie11 issue #1530 - Fix date selection in the SDP
@svvb it should be fixed in v20.2. if not, please file a new issue. |
react-dates version
e.g. react-dates@18.4.1
Describe the bug
In, IE11, SingleDatePicker renders and opens on focus. But when I click on a date, the calendar disappears without updating the date in the input. This works fine on other browsers.
Desktop (please complete the following information):
Is the issue reproducible in Storybook?
https://airbnb.io/react-dates/?selectedKind=SingleDatePicker%20%28SDP%29&selectedStory=default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
The text was updated successfully, but these errors were encountered: