Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocked navigation (min/maxDate) stories #1598

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@ianduvall
Copy link

ianduvall commented Mar 26, 2019

This fixes two stories around blocked navigation with min and max dates. This change keeps today always between the min and max dates which makes the expected behavior of the story easier to understand.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage remained the same at 84.494% when pulling ee0b11e on ianduvall:update-blocked-navigation-stories into 5f1964b on airbnb:master.

@pedroabreu
Copy link
Contributor

pedroabreu left a comment

Makes sense to me 👍

@ianduvall

This comment has been minimized.

Copy link
Author

ianduvall commented Apr 3, 2019

@ljharb @majapw thoughts?

@ljharb

ljharb approved these changes Apr 3, 2019

Copy link
Member

ljharb left a comment

Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.