Optimize isDayVisible #1657
Merged
Optimize isDayVisible #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
added
semver-patch: fixes/refactors/etc
ljharb
approved these changes
May 30, 2019
lencioni
force-pushed
the
isdayvisible-opt
branch
3 times, most recently
from
8db2c47
to
0c35128
Compare
Cloning is a little expensive, so we want to do it as little as possible. Here we clone the month once and keep mutating that moment object. In my profiling this change by itself appears to reduce the amount of time spent in this function when updating DayPickeRangeController from ~16ms to ~11ms, with almost all of the time being spent in Moment clone.
lencioni
force-pushed
the
isdayvisible-opt
branch
from
0c35128
to
5e0c8c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning is a little expensive, so we want to do it as little as possible.
Here we clone the month once and keep mutating that moment object.
In my profiling this change by itself appears to reduce the amount of
time spent in this function when updating DayPickeRangeController from
~16ms to ~11ms, with almost all of the time being spent in Moment clone.