Cache some moment instances when rebuilding modifiers #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
added
semver-patch: fixes/refactors/etc
ljharb
reviewed
May 31, 2019
ljharb
approved these changes
May 31, 2019
|
@ljharb any idea why coverage dropped? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ljharb
reviewed
May 31, 2019
When modifiers need to be rebuilt, which happens pretty frequently, we iterate over every day and create a new moment instance for these operations. These moment instances are never mutated, so we can safely store and reuse them to improve performance. This optimization reduces the time spent in DayPickerRangeController#componentWillReceiveProps when selecting dates from ~16ms to ~6-10ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifiers need to be rebuilt, which happens pretty frequently, we
iterate over every day and create a new moment instance for these
operations. These moment instances are never mutated, so we can safely
store and reuse them to improve performance.
This optimization reduces the time spent in
DayPickerRangeController#componentWillReceiveProps when selecting dates
from ~16ms to ~6-10ms.
Before:
After:
And here it is with a production build with 4x CPU slowdown.
Before:
After:
