Add guard for undefined objects in addModifier #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
added
the
semver-patch: fixes/refactors/etc
nkinser
approved these changes
Jun 4, 2019
ljharb
approved these changes
Jun 4, 2019
|
@ljharb Totally agreed about the test, but I wasn't sure how this could happen so I wasn't sure how to write the test. Reading over the code again though, I think I see what I got confused about and I'll try to get a test in (I think I can also simplify my change). |
After updating to v20.2.1, we started seeing a handful of errors about `undefined is not an object` coming from these addModifier calls. It isn't entirely clear to me how this happens, but I think we can prevent it from being a problem by adding some guards in these codepaths.
|
@ljharb PR updated, PTAL |
ljharb
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to v20.2.1, we started seeing a handful of errors about
undefined is not an objectcoming from these addModifier calls. Itisn't entirely clear to me how this happens, but I think we can prevent
it from being a problem by adding some guards in these codepaths.