Update to Storybook v5 #1673
Merged
Update to Storybook v5 #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running into issues making a static Storybook build on v4 of Storybook (see react-dates#1382 (comment)). The error I'm seeing is something like ERR! ./examples/DateRangePickerWrapper.jsx ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js): ERR! TypeError: Property declarations[0] of VariableDeclaration expected node to be of a type ["VariableDeclarator"] but instead got "ExpressionStatement" ERR! at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:128:13) ERR! at validator (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:97:7) ERR! at Object.validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:172:7) ERR! at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/validators/validate.js:17:9) ERR! at builder (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/builders/builder.js:46:27) ERR! at Object.VariableDeclaration (/home/travis/build/airbnb/react- It seems to happen at the minification step, because right before that error happens I'm seeing "92% chunk asset TerserPlugin". I started going down the route of tracing this down in Storybook v4, but then decided to give v5 a spin instead. It turns out the upgrade isn't all that complicated, and it does resolve the error I was seeing. The only change needed except for bumping all the @storybook dependencies was to turn the webpack config from "extend mode" to "full control mode". See https://storybook.js.org/docs/configurations/custom-webpack-config/ I used this guide as a starting point to the upgrade: https://medium.com/storybookjs/storybook-5-migration-guide-d804b38c739d
ljharb
approved these changes
Jun 5, 2019
We can just push multiple objects into the array in one go.
|
✅ local storybook |
|
Thanks for the quick review @ljharb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues making a static Storybook build on v4 of
Storybook (see #1382 (comment)).
The error I'm seeing is something like
ERR! ./examples/DateRangePickerWrapper.jsx
ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js):
ERR! TypeError: Property declarations[0] of VariableDeclaration expected node to be of a type ["VariableDeclarator"] but instead got "ExpressionStatement"
ERR! at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:128:13)
ERR! at validator (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:97:7)
ERR! at Object.validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:172:7)
ERR! at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/validators/validate.js:17:9)
ERR! at builder (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/builders/builder.js:46:27)
ERR! at Object.VariableDeclaration (/home/travis/build/airbnb/react-
It seems to happen at the minification step, because right before that
error happens I'm seeing "92% chunk asset TerserPlugin".
I started going down the route of tracing this down in Storybook v4, but
then decided to give v5 a spin instead. It turns out the upgrade isn't
all that complicated, and it does resolve the error I was seeing.
The only change needed except for bumping all the @storybook
dependencies was to turn the webpack config from "extend mode" to "full
control mode". See https://storybook.js.org/docs/configurations/custom-webpack-config/
I used this guide as a starting point to the upgrade:
https://medium.com/storybookjs/storybook-5-migration-guide-d804b38c739d