Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that focusedInput: null constrains input #1745

Closed
wants to merge 2 commits into from
Closed

clarify that focusedInput: null constrains input #1745

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
266745f
clarify that focusedInput: null constrains input
dcousens Aug 8, 2019
61b8c39
README: clarify undefined too
dcousens Sep 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -286,7 +286,7 @@ dayAriaLabelFormat: PropTypes.string,
#### DayPickerRangeController
The `DayPickerRangeController` is a calendar-only version of the `DateRangePicker`. There are no inputs (which also means
that currently, it is not keyboard accessible) and the calendar is always visible, but you can select a date range much in the same way you would with the `DateRangePicker`. You can control the selected
dates using the `startDate`, `endDate`, and `onDatesChange` props as shown below. Similarly, you can control which input is focused with the `focusedInput` and `onFocusChange` props as shown below. The user will only be able to select a date if `focusedInput` is provided.
dates using the `startDate`, `endDate`, and `onDatesChange` props as shown below. Similarly, you can control which input is focused with the `focusedInput` and `onFocusChange` props as shown below. The user will only be able to select a date if `focusedInput` is not `null`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, a prop that’s null or undefined is considered “not provided” - I’m fine with this alternative wording, but it’d need to include undefined as well.


Here is the minimum *REQUIRED* setup you need to get the `DayPickerRangeController` working:
```jsx
Expand Down