Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all direct imports of css in favor of injected prop #1758

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Remove all direct imports of css in favor of injected prop #1758

merged 1 commit into from
Aug 16, 2019

Conversation

noratarano
Copy link
Contributor

@noratarano noratarano commented Aug 15, 2019 •
edited
Loading

Summary

Remove all direct imports of css in favor of the css injected prop. This is the preferred usage and is a pre-req to using contextual react-with-styles.

Reviewers

@majapw @TaeKimJR @ahuth

@noratarano noratarano requested review from ljharb, nkinser, majapw, alejandrogarciasalas and goatslacker and removed request for ljharb and nkinser August 15, 2019 23:58
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.895% when pulling 8a6d220 on nora--remove-direct-imports-of-css into 8c0ba98 on master.

@ljharb
Copy link
Member

ljharb commented Aug 16, 2019

Failing test seemed due to flakiness at UTC midnight; i reran.

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Aug 16, 2019
alejandrogarciasalas
alejandrogarciasalas approved these changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@alejandrogarciasalas alejandrogarciasalas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :D

@noratarano noratarano merged commit 3e66eba into master Aug 16, 2019
@noratarano noratarano deleted the nora--remove-direct-imports-of-css branch August 16, 2019 01:44
@mstanaland mstanaland mentioned this pull request Aug 26, 2019
Open
@noratarano noratarano mentioned this pull request Sep 10, 2019
Merged
noratarano pushed a commit that referenced this pull request Oct 1, 2019
Revert "Merge pull request #1758 from airbnb/nora--remove-direct-impo…
08e9079 
…rts-of-css"

This reverts commit 3e66eba, reversing
changes made to 8c0ba98.
@noratarano noratarano mentioned this pull request Oct 1, 2019
Merged
noratarano added a commit that referenced this pull request Oct 1, 2019
@noratarano
Merge pull request #1818 from airbnb/nora--revert-css-prop
fd1e903 
Revert "Merge pull request #1758 from airbnb/nora--remove-direct-imports-of-css"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@alejandrogarciasalas alejandrogarciasalas alejandrogarciasalas approved these changes

@majapw majapw Awaiting requested review from majapw

@nkinser nkinser Awaiting requested review from nkinser

@goatslacker goatslacker Awaiting requested review from goatslacker

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noratarano @coveralls @ljharb @alejandrogarciasalas