Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onMultiplyScrollableMonths to SingleDatePicker #1770

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Add onMultiplyScrollableMonths to SingleDatePicker #1770

merged 1 commit into from
Aug 29, 2019

Conversation

mmarkelov
Copy link
Contributor

Fix #1768

@coveralls
Copy link

coveralls commented Aug 29, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 84.958% when pulling 962d5bf on mmarkelov:Add_onMultiplyScrollableMonths_to_SingleDatePicker into cc1e339 on airbnb:master.

ljharb
ljharb requested changes Aug 29, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you provide some tests for this?

@mmarkelov
Copy link
Contributor Author

@ljharb youp! sure!

@ljharb
Copy link
Member

ljharb commented Aug 29, 2019

@mmarkelov it'd be ideal to add new tests instead of changing existing ones; that way it's super clear it's not a breaking change :-)

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Aug 29, 2019
@ljharb ljharb merged commit 962d5bf into react-dates:master Aug 29, 2019
@noratarano noratarano mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isOutsideRange not called for new months in verticalScrollable SingleDatePicker
3 participants
@mmarkelov @coveralls @ljharb