Call getStateForNewMonth when date/startDate/endDate is set to a date that is not visible #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noratarano
reviewed
Oct 12, 2019
| ) { | ||
| const newMonthState = this.getStateForNewMonth(nextProps); | ||
| const { currentMonth } = newMonthState; | ||
| ({ visibleDays } = newMonthState); | ||
| ({ currentMonth, visibleDays } = newMonthState); |
There was a problem hiding this comment.
Not real feedback: Why does this need to be wrapped in parens like this? 🤔
There was a problem hiding this comment.
@noratarano I thiiiink it’s to destructure into a let assignment—this is also the first time I’ve seen this :)
noratarano
approved these changes
Oct 12, 2019
… that is not visible
majapw
force-pushed
the
caseklim--update-state-if-unvisible-date
branch
from
1134f83
to
862c99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
date,startDate, orendDateis set externally by a different date input, this will bring the month with the newly selected date into view.