Allow for custom month navigation buttons #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
caseklim
commented
Nov 13, 2019
caseklim
commented
caseklim
force-pushed
the
ck--custom-month-navigation-buttons
branch
6 times, most recently
from
45194a1
to
733ba64
Compare
kevinthepan
reviewed
Nov 13, 2019
| @@ -469,8 +473,10 @@ class DateRangePicker extends React.PureComponent { | |||
|
|
|||
| const withAnyPortal = withPortal || withFullScreenPortal; | |||
|
|
|||
| /* eslint-disable jsx-a11y/no-static-element-interactions */ | |||
There was a problem hiding this comment.
Is this not doable in the same inline comment?
There was a problem hiding this comment.
oooh TIL https://stackoverflow.com/a/56714489
caseklim
force-pushed
the
ck--custom-month-navigation-buttons
branch
from
733ba64
to
a75682b
Compare
kevinthepan
reviewed
Nov 13, 2019
src/components/DateRangePicker.jsx
Outdated
| @@ -469,8 +473,9 @@ class DateRangePicker extends React.PureComponent { | |||
|
|
|||
| const withAnyPortal = withPortal || withFullScreenPortal; | |||
|
|
|||
| /* eslint-disable jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events */ | |||
There was a problem hiding this comment.
Can we move it down to where it originally was and use eslint-disable-line
There was a problem hiding this comment.
done 👌 I was trying to stay within the character limit but the line length is too long either way lol
caseklim
force-pushed
the
ck--custom-month-navigation-buttons
branch
from
a75682b
to
de15781
Compare
caseklim
force-pushed
the
ck--custom-month-navigation-buttons
branch
from
de15781
to
35effaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.