Remove overflowY:scroll on CalendarMonthGrid #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaesonho
deleted the
kaesonho--remove-overflow-scroll-on-calendarmonth-grid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this makes sense, but for vertical scrollable, we rely on the DayPicker container to do vertical scrolling, https://github.com/airbnb/react-dates/blob/7c58d6d6aadf0061980f1adeb52465c2606d58ac/src/components/DayPicker.jsx#L1310
and CalendarMonthGrid works as the content inside it, it doesn't look like we need a overflowY:scroll here
https://github.com/airbnb/react-dates/blob/7c58d6d6aadf0061980f1adeb52465c2606d58ac/src/components/CalendarMonthGrid.jsx#L399
with this it seems cause double scroll bars in some browsers. for this case, it's
Chrome 78, Google Pixel 3, 9.0@caseklim @kevinthepan @noratarano @ljharb