Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to not show prev or next navigation buttons #1900

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

nkinser
Copy link
Contributor

@nkinser nkinser commented Jan 14, 2020

Add capability to not show prev or next navigation buttons.

No nav prev

no-nav-prev

No nav next

no-nav-next

@nkinser nkinser requested review from ljharb, majapw and kevinthepan and removed request for ljharb January 14, 2020 18:24
@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Jan 14, 2020
@nkinser nkinser force-pushed the nk--hide-navigation-buttons branch 4 times, most recently from 10df582 to 903cd9c Compare January 14, 2020 19:09
@nkinser
Copy link
Contributor Author

nkinser commented Jan 14, 2020

@ljharb Tests are failing for only certain versions of node and react. Any suggestions on how to fix this?

@ljharb
Copy link
Member

ljharb commented Jan 14, 2020

@nkinser ah - return null from an SFC requires React 15+; one solution is to make it a class component (simplest); another is to return an empty div; another is to try to detect react < 15 and return an empty div only in that case.

@nkinser nkinser merged commit 71b4e5d into react-dates:master Jan 14, 2020
@nkinser nkinser deleted the nk--hide-navigation-buttons branch January 14, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants