Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding date to displayFormat parameters #2086

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mgm793
Copy link

@mgm793 mgm793 commented Jan 28, 2021

This PR solves this #2085

It pass a date to displayFormat and then user can use this date to format it and return it.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will need tests.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Feb 24, 2021
@mgm793
Copy link
Author

mgm793 commented Mar 3, 2021

Thanks, this will need tests.

Done :D

@mgm793 mgm793 requested a review from ljharb March 3, 2021 09:27
@mgm793
Copy link
Author

mgm793 commented Aug 11, 2021

@ljharb can you check it again?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We still need a test for SingleDatePickerInputController though.

@mgm793 mgm793 closed this Dec 1, 2021
@ljharb ljharb reopened this Dec 1, 2021
@ljharb
Copy link
Member

ljharb commented Dec 1, 2021

@mgm793 if you're not interested in finishing this, please leave it open so somebody else can.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #2086 (4d9b682) into master (b7bad38) will increase coverage by 79.99%.
The diff coverage is 100.00%.

❗ Current head 4d9b682 differs from pull request most recent head 5fdfd3e. Consider uploading reports for the commit 5fdfd3e to get more accurate results

@@             Coverage Diff             @@
##           master    #2086       +/-   ##
===========================================
+ Coverage        0   79.99%   +79.99%     
===========================================
  Files           0       57       +57     
  Lines           0     2299     +2299     
  Branches        0      638      +638     
===========================================
+ Hits            0     1839     +1839     
- Misses          0      271      +271     
- Partials        0      189      +189     
Impacted Files Coverage Δ
src/components/SingleDatePickerInputController.jsx 92.68% <ø> (ø)
src/components/DateRangePickerInputController.jsx 95.08% <100.00%> (ø)

... and 55 files with indirect coverage changes

@mgm793 mgm793 closed this Sep 2, 2022
@ljharb ljharb reopened this Sep 2, 2022
@mgm793 mgm793 closed this Jun 15, 2023
@ljharb ljharb reopened this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants