Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix week header width issue over 2 months #221

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Dec 19, 2016

So I started thinking about #191 as well as @securityinsanity's solution #199

I think the end that I came to was that... the percentage code was trying too hard. The best bet for the week headers would be to get the style to match the actual CalendarMonths directly, right?

Well, turns out we have access to the width we're using right now both in the css and in the JS (incidentally, it's not very moddable at presence), so let's just go with that. This change does that and thus allows for like a real, > 2 months implementation without looking gross.

to: @securityinsanity @airbnb/webinfra

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Dec 19, 2016
@majapw majapw requested a review from ljharb December 19, 2016 16:17
@Mythra
Copy link
Contributor

Mythra commented Dec 19, 2016

I actually like this idea a lot better. Rather than trying to calculate this weird percentage (where I was still caught up). Seems a lot better to do it this way.

I noticed you added a story for 3 months, I assume (based on looking at this PR), that this should scale to >4 months too, which is always cool sauce.

I think I'll go ahead, and close #199 out in favor of this one.

@majapw
Copy link
Collaborator Author

majapw commented Dec 19, 2016

Awesome. Thanks for the vote of confidence (and doing the hard work of determining the percentages are a bad idea X_x)!

And yeah, I checked it at 4 months and it works as well, but it didn't seem necessary to add both stories.

🎉 incidentally, i'm on a PR/issue rooollll today. #vacation

@Mythra
Copy link
Contributor

Mythra commented Dec 19, 2016

Yea I think adding both stories is a bit unnecessary as long as it shows >2 months.

As for the vacation you aren't alone! I think I made all of my PRs except #199 to this repo while on vacation as well. 🎉 #vacation (clearly the PR didn't end up working out because I wasn't on vacation.)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 86.483% when pulling e506f92 on maja-fix-week-headers-width-issue into 08906d6 on master.

@majapw majapw merged commit bc60da7 into master Dec 20, 2016
@majapw majapw deleted the maja-fix-week-headers-width-issue branch December 20, 2016 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants