Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes regression where user was unable to type into the input field #269

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Fixes regression where user was unable to type into the input field #269

merged 1 commit into from
Jan 26, 2017

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jan 26, 2017

Fix for a regression created in #229.

Thanks @timhwang21 for bringing it up here - #79 (comment)

I even added a test @ljharb!

PTAL @airbnb/webinfra

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 26, 2017
gdborton
gdborton approved these changes Jan 26, 2017
View reviewed changes
Copy link

@gdborton gdborton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ tests.

ljharb
ljharb approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.857% when pulling adaa921 on maja-fix-input-regression into a454835 on master.

@majapw majapw merged commit 2345253 into master Jan 26, 2017
@majapw majapw deleted the maja-fix-input-regression branch January 26, 2017 23:10
@majapw majapw mentioned this pull request Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@gdborton gdborton gdborton approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@majapw @coveralls @ljharb @gdborton