Remove mouse{down,up} and touch{start,end,tap} #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
the
semver-major: breaking change
Simplify by using click handler exclusively. This speeds up the scrollable daypicker by avoid touch callbacks.
moonboots
force-pushed
the
remove-touch-handlers
branch
from
91c40fd
to
7305efb
Compare
|
Oh! I didn't realize you wanted to remove this completely. I suppose have fewer handlers floating around might help with performance as well. This seems reasonable to me (but is def breaking). |
majapw
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @majapw
Replaces mouse and touch handlers in favor of
onClick/onDayClick. I think these mouse/touch handlers support functionality that's no longer used. This change should improve scroll performance on mobile because the browser doesn't need to interrupt scrolling to handle touchstart/end.