Fix blinking cursor on iOS #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Feb 7, 2017
css/DateInput.scss
Outdated
| @@ -50,6 +50,13 @@ $caret-top: $react-dates-spacing-vertical-picker - $react-dates-width-tooltip-ar | |||
| border: 0; | |||
| height: 100%; | |||
| width: 100%; | |||
|
|
|||
| &[readonly] { | |||
| user-select: none; | |||
There was a problem hiding this comment.
the standard property should always go last, so that it takes precedence in browsers that support both.
|
LGTM after @ljharb's comment is addressed. Thanks for this, @moonboots! |
|
Cool. Can you squash the commits into one before we merge tho? |
The readonly attribute on touch inputs hides the keyboard, but recently the cursor started appearing. Adding touch events removes the flashing cursor. Dogfalo/materialize#2448 Also moved unprefixed properties last
moonboots
force-pushed
the
touch-input-fix
branch
from
1d23957
to
844ce6d
Compare
ljharb
approved these changes
Feb 7, 2017
ljharb
added
the
semver-patch: fixes/refactors/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @majapw @ljharb
Removes the blinking cursor appearing in DateInput on iOS by adding
user-select: none;(recommended as a workaround in another project). This PR should resolve the "Blinking cursor in mobile" issue.Here's a gif of the blinking cursor and "Done" bottom bar:
