[Feature] add "renderMonth" support + add Persian locale story #449
Conversation
cyclops24
changed the title
cyclops24
changed the title
| @@ -104,7 +107,7 @@ export default class CalendarMonth extends React.Component { | |||
| } = this.props; | |||
|
|
|||
| const { weeks } = this.state; | |||
| const monthTitle = month.format(monthFormat); | |||
| const monthTitle = renderMonth ? renderMonth(month) : month.format(monthFormat); | |||
There was a problem hiding this comment.
If we're calling a user function here, we'd need to somehow assert that monthTitle is a string, to match month.format() - and throw if not.
There was a problem hiding this comment.
So what is your suggestion?
I do this part as a code that now exist in CalendarDay component:
https://github.com/airbnb/react-dates/blob/master/src/components/CalendarDay.jsx#L131
There was a problem hiding this comment.
hm, ok, fair point. this can stay as-is, and we can address them all holistically in the future.
There was a problem hiding this comment.
OK, @ljharb So any other change needs for this PR?
| @@ -1,5 +1,6 @@ | |||
| import React from 'react'; | |||
| import moment from 'moment'; | |||
| import momentJalaali from 'moment-jalaali'; | |||
There was a problem hiding this comment.
Does this need to be added as a dev dep?
There was a problem hiding this comment.
Yes, Sorry I missed it. It's added to devDependencies now. Please check it again.
majapw
force-pushed
the
feature/renderMonth
branch
from
06baeea
to
19f0af3
Compare
This PR add
renderMonthto react-dates and help to add custom calendar like Jalali (Persian) calendar in future.It's needed for #447
This is a simple screenshot from story page:
