Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some small feature bugs introduced in v11 #489

Merged

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented May 4, 2017

This fixes a couple of bugs that I noticed when trying to update airbnb's version.

  • backwards ranges were broken due to weirdness with initialVisibleMonth changes triggering early
  • selected-spans were not being cleared properly
  • fix 'after-hovered-start' modifiers implementation (Regression of minimum nights hover with release 11.0.0 #487)
  • fix active state/hover state of last element in range

Probably I need to add some tests.

to: @airbnb/webinfra @moonboots

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label May 4, 2017
@majapw majapw force-pushed the maja-quick-fix-on-some-lost-features-in-perf-rearchitecting branch from e496312 to 50585fd Compare May 4, 2017 22:02
@coveralls
Copy link

coveralls commented May 4, 2017

Coverage Status

Coverage decreased (-0.01%) to 85.726% when pulling 50585fd on maja-quick-fix-on-some-lost-features-in-perf-rearchitecting into 5c533e8 on master.

@coveralls
Copy link

coveralls commented May 4, 2017

Coverage Status

Coverage decreased (-0.01%) to 85.726% when pulling 50585fd on maja-quick-fix-on-some-lost-features-in-perf-rearchitecting into 5c533e8 on master.

- backwards ranges were broken due to weirdness with initialVisibleMonth changes triggering early
- selected-spans were not being cleared properly
- fix 'after-hovered-start' modifiers implementation
- fix active state/hover state of last element in range
@majapw majapw force-pushed the maja-quick-fix-on-some-lost-features-in-perf-rearchitecting branch from 50585fd to 756f5c4 Compare May 5, 2017 18:13
@coveralls
Copy link

coveralls commented May 5, 2017

Coverage Status

Coverage increased (+1.09%) to 86.83% when pulling 756f5c4 on maja-quick-fix-on-some-lost-features-in-perf-rearchitecting into 5c533e8 on master.

@majapw majapw merged commit 9bc1470 into master May 5, 2017
@majapw majapw deleted the maja-quick-fix-on-some-lost-features-in-perf-rearchitecting branch May 5, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants