Bump moment and remove locale tests #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
previously approved these changes
May 11, 2017
majapw
force-pushed
the
maja-fix-locale-tests
branch
from
cd70052
to
b6650af
Compare
ljharb
approved these changes
May 11, 2017
ljharb
added
semver-major: breaking change
ljharb
approved these changes
May 11, 2017
| @@ -113,7 +113,7 @@ | |||
| "react-portal": "^3.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "moment": "2.10 - 2.14 || ~2.15.1 || ~2.16 || ~2.17", | |||
| "moment": "^2.18.1", | |||
There was a problem hiding this comment.
to be a patch, this needs to be 2.10 - 2.14 || ~2.15.1 || ~2.16 || ~2.17 || ^2.18.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #497
We were pegging moment to a lower version because a number of our date conversion tests were testing for format explicitly and moment frequently updates locale formats in minor and patch releases. This updates moment and removes the offending tests.
The tests are a bit of a relic of when this repository was internal to Airbnb. At that time, the formatted string values were being passed around and had to be in a specific format or face breaking pages. Now that there's a bit of healthy separation (the input elements themselves use ISO format and the callbacks from the components all pass around moment objects instead of strings) the locale tests don't do as much for us within the repo itself. :) As such, just knowing the
toLocalizedDateString,toMomentObject, andtoISODateStringall handle theLformat appropriately is enough.to: @ljharb @jasonkb @airbnb/webinfra