Adds null check for this.calendarMonthGrid ref #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
previously approved these changes
Jun 8, 2017
src/components/DayPicker.jsx
Outdated
| ); | ||
| // eslint-disable-next-line react/no-find-dom-node | ||
| const calendarMonthGridDOMNode = ReactDOM.findDOMNode(this.calendarMonthGrid); | ||
| if (calendarMonthGridDOMNode) { |
There was a problem hiding this comment.
i'd actually wrap the findDOMNode in a truthy check for the ref; if it's nullary, there's no point in doing the findDOMNode
src/components/DayPicker.jsx
Outdated
| ); | ||
| // eslint-disable-next-line react/no-find-dom-node | ||
| const calendarMonthGridDOMNode = ReactDOM.findDOMNode(this.calendarMonthGrid); | ||
| if (calendarMonthGridDOMNode) { |
majapw
force-pushed
the
maja-add-null-check-for-calendarmonthgrid
branch
2 times, most recently
from
d911d10
to
79daa93
Compare
majapw
force-pushed
the
maja-add-null-check-for-calendarmonthgrid
branch
from
79daa93
to
74868bf
Compare
ljharb
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #529
This should probably address #529. Having the ref be set in a constructor-bound method instead of in an inline arrow function should prevent the ref from being set to null unless it is unmounted. The extra null check should, in edge cases we are not thinking of, prevent the error itself from being thrown.
to: @ljharb @jherencia @johnryan