Fixes edge-case CalendarMonth height issue
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
force-pushed
the
fix-CalendarMonth-height-issue
branch
from
72e30f7
to
d9ccfd5
Compare
|
LGTM |
majapw
force-pushed
the
fix-CalendarMonth-height-issue
branch
from
d9ccfd5
to
9b32cd3
Compare
…nth began at the beginning of the week
majapw
force-pushed
the
fix-CalendarMonth-height-issue
branch
from
9b32cd3
to
58030d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that sometimes the height of the datepicker was not rendering correctly, specifically that the table seemed to be an extra row representing the full first week of the following month:
Turns out, when the next month starts at the beginning of the week (according to whatever locale you're in), we still render that full week as outside days.
I also discovered that this was a ticking time bomb as related to the tests for
getCalendarMonthWeeksthat would have started breaking in December. As a result I've added some tests to cover this edgecase as well.