Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move calendar month caption div outside of table #748

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Move calendar month caption div outside of table #748

merged 1 commit into from
Oct 6, 2017

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Oct 6, 2017

In a bad rebase, I left this div inside the table which caused... problems.

to: @ljharb

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Oct 6, 2017
ljharb
ljharb approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely better to put things on top of tables instead of inside them

┬─┬ノ( º _ ºノ)

@majapw
Copy link
Collaborator Author

majapw commented Oct 6, 2017

😆

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.733% when pulling b980bab on maja-fix-fucked-table-header into 1471dc3 on master.

@majapw majapw merged commit 7e1429b into master Oct 6, 2017
@majapw majapw deleted the maja-fix-fucked-table-header branch October 6, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majapw @coveralls @ljharb