Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing customCloseIcon prop/usage to SingleDatePicker. #767

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Add missing customCloseIcon prop/usage to SingleDatePicker. #767

merged 1 commit into from
Oct 12, 2017

Conversation

mmaday
Copy link
Contributor

@mmaday mmaday commented Oct 12, 2017

Properly pass the customCloseIcon property from the SingleDatePicker to the SingleDatePickerInput.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.733% when pulling 71c4947 on mmaday:bug/customCloseIcon into 5c2c0fc on airbnb:master.

ljharb
ljharb approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Oct 12, 2017
@majapw
Copy link
Collaborator

majapw commented Oct 12, 2017

LGTM as well!

@majapw majapw merged commit 9f12140 into react-dates:master Oct 12, 2017
@mmaday mmaday deleted the bug/customCloseIcon branch October 12, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmaday @coveralls @majapw @ljharb