Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Pass onClose from SingleDatePicker to DayPickerSingleDateController #816

Merged
merged 2 commits into from
Nov 1, 2017
Merged

[Fix] Pass onClose from SingleDatePicker to DayPickerSingleDateController #816

merged 2 commits into from
Nov 1, 2017

Conversation

erin-doyle
Copy link
Collaborator

I just found a miss here and added it in.

@erin-doyle erin-doyle self-assigned this Nov 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.778% when pulling f30a1a1 on fix_onClose_singleDatePicker into f415c81 on master.

ljharb
ljharb reviewed Nov 1, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you also add a regression test and an example that would have caught this?

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Nov 1, 2017
@erin-doyle
Copy link
Collaborator Author

Yep, I can do that.

Added a regression unit test for the miss of passing onClose from Sin…
a21d3f0 
…gleDatePicker to DayPickerSingleDateController as well as examples of using onClose with SingleDatePicker and DateRangePicker.
@erin-doyle
Copy link
Collaborator Author

Let me know if these were not what you were asking for. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.778% when pulling a21d3f0 on fix_onClose_singleDatePicker into f415c81 on master.

ljharb
ljharb approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb merged commit 9475ca5 into master Nov 1, 2017
@ljharb ljharb deleted the fix_onClose_singleDatePicker branch November 1, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

@erin-doyle erin-doyle

Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erin-doyle @coveralls @ljharb