Add borderless option to the DayPicker variations
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
force-pushed
the
maja-add-borderless-option-to-DayPicker-variants
branch
from
3e933c3
to
456a0fb
Compare
lencioni
previously approved these changes
Nov 30, 2017
lencioni
reviewed
Nov 30, 2017
README.md
Outdated
| @@ -262,6 +262,7 @@ The following is a list of other *OPTIONAL* props you may provide to the `DayPic | |||
| renderCalendarInfo: PropTypes.func, | |||
| onOutsideClick: PropTypes.func, | |||
| keepOpenOnDateSelect: PropTypes.bool, | |||
| borderless: PropTypes.bool, | |||
There was a problem hiding this comment.
I generally like to name props like this noFoo instead of fooless because I think it is easier to be more consistent that way.
There was a problem hiding this comment.
sounds reasonable to me!
majapw
force-pushed
the
maja-add-borderless-option-to-DayPicker-variants
branch
from
456a0fb
to
2bf6476
Compare
|
PTAL @lencioni |
lencioni
approved these changes
Nov 30, 2017
|
(linking to #870) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want the DayPicker to have a border (or you want to have full control of the border prop yourself)! This adds that option.
This is one PR in what will probably be a series of style props to help get airbnb.com onto the latest and greatest. Hopefully these new additions will help others customize to their heart's content as well! :)
to: @ljharb @erin-doyle @noratarano @airbnb/webinfra