Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for CustomizableCalendarDay #962

Merged

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Jan 19, 2018

Whoops! Somehow I missed the selected styles the first time around.

Also, whenever hasCustomStyles ended up accidentally null, everything would break which was a downer.

@ljharb can you take a quick look?

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Jan 19, 2018
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression test? :-D

@majapw
Copy link
Collaborator Author

majapw commented Jan 19, 2018

All styles-based unfortunately :/

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.329% when pulling d188c27 on maja-fix-weird-bug-when-only-blocked-dates-are-customized into 05b17b0 on master.

@majapw majapw merged commit 9230ba8 into master Jan 19, 2018
@majapw majapw deleted the maja-fix-weird-bug-when-only-blocked-dates-are-customized branch January 19, 2018 01:05
@ljharb
Copy link
Member

ljharb commented Jan 19, 2018

@majapw sure but simply exercising this code would have thrown an error, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants