Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTConvert+MapKit.h #1193

Closed
karpoff opened this issue Apr 5, 2017 · 14 comments
Closed

RCTConvert+MapKit.h #1193

karpoff opened this issue Apr 5, 2017 · 14 comments

Comments

@karpoff
Copy link

karpoff commented Apr 5, 2017

https://github.com/airbnb/react-native-maps/blob/master/lib/ios/AirMaps.xcodeproj/project.pbxproj
it still have links to RCTConvert+MapKit.h/m (whick was renamed to RCTConvert+AirMap.h/h here 4926f5b)
it causes ios build errors

changing AirMaps project file (removig old files and adding new ones) can be used as workaround

@doananh234
Copy link

open libraries -> right click AirMaps.xcodeproj -> add file to AirMaps -> go to find react-native-maps into node_module -> lib -> ios -> AirMaps -> select RCTConvert+MapKit.h/m -> add

maybe help you.

@karpoff
Copy link
Author

karpoff commented Apr 5, 2017

@doananh234 those files were replaced by RCTConvert+AirMap.h/m
https://github.com/airbnb/react-native-maps/tree/master/lib/ios/AirMaps

@Panda313
Copy link

Panda313 commented Apr 6, 2017

I got the same error as you. I Just did what @doananh234 suggested but instead of adding "RCTConvert+MapKit.h/m" I looked for "RCTConvert+AirMap.h/m" inside node_modules/react-air-maps.

The files were actually in red inside xcode, certainly not well linked.

Anyway, did the trick for me

@karpoff
Copy link
Author

karpoff commented Apr 6, 2017

yep. this way works for me to
open AirMaps project inside Libraries folder
remove reference of RCTConvert+MapKit.h/m
add reference to RCTConvert+AirMap.h/m (from node_modules/react-native-maps/lib/ios/AirMaps)

@mhaagens
Copy link

@karpoff has the correct solution. Go to Libraries/AirMaps.xcodeproj/AirMaps/ and remove the references to RCTConvert+MapKit.h/m and then add RCTConvert+AirMap.h/m.

@axxag
Copy link

axxag commented Apr 20, 2017

Wrote a simple shell script to fix react-native-maps build errors that gets run whenever i rebuild my project. Maybe it'll be helpful to someone:

sed -ie 's/RCTConvert\+MapKit\.m/RCTConvert\+AirMap\.m/g' node_modules/react-native-maps/lib/ios/AirMaps.xcodeproj/project.pbxproj
sed -ie 's/RCTConvert\+MapKit\.h/RCTConvert\+AirMap\.h/g' node_modules/react-native-maps/lib/ios/AirMaps.xcodeproj/project.pbxproj
rm -f node_modules/react-native-maps/.babelrc

@JonatanSalas
Copy link

@agentilela your solution works like a charm!

@creeperyang
Copy link

@karpoff thanks for your solution. And my env is

"dependencies": {
    "react": "16.0.0-alpha.6",
    "react-native": "0.43.4",
    "react-native-maps": "^0.14.0"
  }

Just remove RCTConvert+MapKit.h/m and add RCTConvert+AirMap.h/m.

2017-04-21 6 14 29

@prontiol
Copy link

prontiol commented May 2, 2017

This is not the correct solution, because you have to modify Xcode project from the node_modules folder to make it work. So you basically end up with non-working code in your repo and any other team members will fail to run the project from scratch. Also CI will fail.

@axxag
Copy link

axxag commented May 2, 2017 via email

@npomfret
Copy link

npomfret commented May 3, 2017

Is there a fix on the way for this?

@prontiol
Copy link

prontiol commented May 3, 2017

@npomfret There is a PR #1195.
Also, I have forked and merged this PR in my repo, so you can use it for now, like this:

yarn add prontiol/react-native-maps#hotfix

Don't use this in production though.

@itinance
Copy link

itinance commented Jul 7, 2017

Anything we can do? We faced this issue also on a green field application based on RN 0.45. I'm curious why this is closed.

@christopherdro
Copy link
Collaborator

This was closed because the fix has been merged via 4b861c9 released in version 0.15.0.

@itinance If your application is currently on RN 0.45 then you'll have to update to 0.15+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests