-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCTConvert+MapKit.h #1193
Comments
open libraries -> right click AirMaps.xcodeproj -> add file to AirMaps -> go to find react-native-maps into node_module -> lib -> ios -> AirMaps -> select RCTConvert+MapKit.h/m -> add maybe help you. |
@doananh234 those files were replaced by RCTConvert+AirMap.h/m |
I got the same error as you. I Just did what @doananh234 suggested but instead of adding "RCTConvert+MapKit.h/m" I looked for "RCTConvert+AirMap.h/m" inside node_modules/react-air-maps. The files were actually in red inside xcode, certainly not well linked. Anyway, did the trick for me |
yep. this way works for me to |
@karpoff has the correct solution. Go to Libraries/AirMaps.xcodeproj/AirMaps/ and remove the references to RCTConvert+MapKit.h/m and then add RCTConvert+AirMap.h/m. |
Wrote a simple shell script to fix react-native-maps build errors that gets run whenever i rebuild my project. Maybe it'll be helpful to someone:
|
@agentilela your solution works like a charm! |
@karpoff thanks for your solution. And my env is
Just remove |
This is not the correct solution, because you have to modify Xcode project from the |
I added it to my postinstall scripts so it doesn't break CI. But yeah, it's
not the correct solution. We need a version with the fixes merged.
…On Mon, May 1, 2017 at 23:15 Denys Mikhalenko ***@***.***> wrote:
This is not correct solution, because you have to modify Xcode Project
from the node_modules folder to make it work. So you basically end up
with non-working code in your repo and any other team member will fail to
run the project from scratch. Also CI will fail.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1193 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIfvWifJVeJDzhRmXKgJPrgrVEBpui_zks5r1vRMgaJpZM4Mz-Oi>
.
|
Is there a fix on the way for this? |
Anything we can do? We faced this issue also on a green field application based on RN 0.45. I'm curious why this is closed. |
https://github.com/airbnb/react-native-maps/blob/master/lib/ios/AirMaps.xcodeproj/project.pbxproj
it still have links to RCTConvert+MapKit.h/m (whick was renamed to RCTConvert+AirMap.h/h here 4926f5b)
it causes ios build errors
changing AirMaps project file (removig old files and adding new ones) can be used as workaround
The text was updated successfully, but these errors were encountered: