Fixed crash caused by Android map lifecycle methods being called out of order.

[timxyz]

We found an intermittent crash caused by LifecycleEventListener.onHostResume being called after doDestroy. This caused an internal crash in MapView, presumably due to its onResume method being called after onDestroy.

Crash was as follows:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke interface method 'void com.google.maps.api.android.lib6.impl.bq.o()' on a null object reference
       at com.google.maps.api.android.lib6.impl.da.b(:com.google.android.gms.DynamiteModulesB:96)
       at com.google.android.gms.maps.internal.z.onTransact(:com.google.android.gms.DynamiteModulesB:73)
       at android.os.Binder.transact(Binder.java:380)
       at com.google.android.gms.maps.internal.IMapViewDelegate$zza$zza.onResume(Unknown Source)
       at com.google.android.gms.maps.MapView$zza.onResume(Unknown Source)
       at com.google.android.gms.dynamic.zza$7.zzb(Unknown Source)
       at com.google.android.gms.dynamic.zza.zza(Unknown Source)
       at com.google.android.gms.dynamic.zza.onResume(Unknown Source)
       at com.google.android.gms.maps.MapView.onResume(Unknown Source)
       at com.airbnb.android.react.maps.AirMapView$12.onHostResume(AirMapView.java:302)
       at com.facebook.react.bridge.ReactContext$1.run(ReactContext.java:165)
       at android.os.Handler.handleCallback(Handler.java:739)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
       at android.os.Looper.loop(Looper.java:135)
       at android.app.ActivityThread.main(ActivityThread.java:5272)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:909)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:704)

This PR also adds in previously missing onStart and onStop calls: the docs expect the MapView to receive the lifecycle methods of its parent activity or fragment, and so we should try to replicate such a lifecycle as closely as possible with the AirMapView.

[christopherdro]

/cc @felipecsl

[felipecsl]

I'd like to avoid these band-aid solutions for Android crashes and do it the proper way through #1306 instead. I'll keep open until that one merges, so if @timxyz can retest and we can make sure it fixes the problem :)

[timxyz]

#1306 does not seem to address this crash at all. I can still see the same problems in AirMapView.

[felipecsl]

@timxyz have you tried the code in that pull request directly?

[timxyz]

I will try it out tomorrow, I was just inspecting it visually for now to see what had changed. There are still missing lifecycle calls.

[felipecsl]

I don't think onHostResume would ever be called for the same Activity after onHostDestroy though

[rborn]

Closing as being an old PR and not a clear reply. Thanks for all the effort 😻