fixed region/initialRegion null overrides of this.props #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atkit
force-pushed
the
fix-region-intial-region
branch
from
5e4834a
to
ecfe964
Compare
aaronbuchanan
added a commit
to aaronbuchanan/react-native-maps
that referenced
this pull request
Oct 20, 2017
onBadge
pushed a commit
to onBadge/react-native-maps
that referenced
this pull request
Oct 31, 2017
onBadge
pushed a commit
to onBadge/react-native-maps
that referenced
this pull request
Oct 31, 2017
|
Can this get merged soon? This bug fix would help a lot as i'm also having issues with #1742 |
|
probably someone from AirBnb can merge it |
|
@larryranches in my experience it can take quite a while for approved changes to make it in, I had to maintain my own fork to speed things up |
atkit
force-pushed
the
fix-region-intial-region
branch
from
ecfe964
to
e5d9bce
Compare
|
@atkit could you please update the PR (so the conflict goes away) maybe we can merge this? 💪 |
atkit
force-pushed
the
fix-region-intial-region
branch
from
e5d9bce
to
2b8b243
Compare
|
LGTM @alvelig |
|
Should be just move the spread down to the bottom? |
|
@christopherdro I think yes, because otherwise the default will overwrite the spread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
props.region and props.initialRegion are always come as null. (even if set for
<MapView />)This change gives ability to set
regionandinitialRegionto something that come from the top.Also it causes big performance issue on RN side when these props are null, (I'll try to mitigate that with different PR)