Add native animation for Markers on Android (with documentation) #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please update the example as well https://github.com/react-community/react-native-maps/blob/master/example/examples/AnimatedMarkers.js Спасибо! |
|
@BEGEMOT9I could you please fix the things travis is complaining ? 🤗 |
|
LGTM @alvelig 🐽 |
|
Great! LGTM |
This was referenced Jan 28, 2018
|
Great improvement! What about iOS, is it already using native drivers for marker animations? |
|
Hi - I am a noob, when i implement this i get an error "expected dynamic type 'double' but had type 'null' (constructing aruments for UIManger.dispatchViewManagerCommand at argument index 1. I am putting the correct arguments into the function- Any idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #1782 with documentation.