Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting to work on iOS with 0.27 #308

Merged
merged 1 commit into from
Jul 9, 2016

Conversation

codenamev
Copy link
Contributor

Ok, so my last PR removed the React dependency as it's latest pod source references an outdated version of 0.14. In order to get this completely working I am doing the following in my project's ios/Podfile:

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!

workspace 'my-project.xcworkspace'
project 'my-project.xcodeproj'

target 'my-project' do
  # Depending on how your project is organized, your node_modules directory may be
  # somewhere else; tell CocoaPods where you've installed react-native from npm
  pod 'React', :path => '../node_modules/react-native'
  pod 'React/Core', path: '../node_modules/react-native'
  pod 'React/RCTGeolocation', :path => '../node_modules/react-native'
  pod 'React/RCTImage', :path => '../node_modules/react-native'
  pod 'React/RCTNetwork', :path => '../node_modules/react-native'
  pod 'React/RCTText', :path => '../node_modules/react-native'
  pod 'React/RCTWebSocket', :path => '../node_modules/react-native'
  pod 'react-native-maps'
end

I then add the React.framework to my Linked Libraries, and everything works. I'm not sure if this is the best way to solve this, but thought I'd post this to start a discussion or help people in the interim.

@JAStanton
Copy link

I want to echo these changes, current master is broken while using CocoaPods

@@ -10,5 +10,7 @@ Pod::Spec.new do |s|

s.source = { :git => "https://github.com/lelandrichardson/react-native-maps.git" }
s.source_files = "ios/AirMaps/**/*.{h,m}"

s.dependency 'React', '0.27.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would s.dependency 'React' be sufficient?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a working fork I dropped the dependency version requirement and it works just fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codenamev in light of #241, I would drop the version.

@lelandrichardson lelandrichardson merged commit b5c2de5 into react-native-maps:master Jul 9, 2016
@akinsella
Copy link

Hi, in case you get same error, just enable same platform than library podspec:

platform :ios, '8.0'

By default, this line is commented when you init a podfile in ios folder from a react native project. By uncommenting it, everything works and error disappear :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants