Update for compatibility with React-Native 0.32 (Android) and fix local installation/building and local React-Native reference #502

chrisknepper · 2016-08-26T01:58:32Z

This pull request seeks to address two issues with react-native-maps on Android.

For a few recent versions of react-native, the constructor signature for the UI Event class changed, causing MapView to crash upon rendering. This is addressed in Update RegionChangeEvent to work with RN 0.32.0-rc #450 and that code change is also included here.
The recommended installation of this plugin (as seen in Instructions.md) states that this module should be required in Gradle like this:

compile 'com.airbnb.android:react-native-maps:0.7.1'

That syntax, combined with the way that the plugin had been structured causes problems. Gradle doesn't recurse/ignores the settings.gradle in this plugin file telling it to include lib, which means that before this change, a user would also need to include this in their app's android/settings.gradle file:

include ':react-native-maps'
project(':react-native-maps').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-maps/android/lib')

Which almost works, but since then it only looks in lib, it ignores the build.gradle in the plugin root telling it where to find the local react-native. These problems combine in a way which causes this plugin to download and reference react-native from Maven, not locally.

On Maven, the newest version of react-native available is 0.20.1. If Gradle gets it from there instead of locally (i.e. 0.32), it fails to build because of the signature change I refer to in point 1.

So bottom line we should reference react-nativefrom the peer node_modules folder, and encourage users of the plugin include it in their app/build.gradle files the new way:

android/app/build.gradle:

compile project(':react-native-maps')

android/settings.gradle:

include ':react-native-maps'
project(':react-native-maps').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-maps/android')

…tdated version from Maven -Update argument signature of RegionChangeEvent constructor to current react-native signature -Temporarily define maven url override in both build.gradle files until we restructure this to remove the lib folder

…t-native projects (for Android)

-Consistent maven URLs

srenault · 2016-08-26T07:54:27Z

Need this!

Exilz · 2016-08-26T10:12:43Z

@chrisknepper It looks great but, I'm might be wrong (I'm not very experienced in native development) but shouldn't compile 'com.facebook.react:react-native:0.32.0' in build.gradle be something like com.facebook.react:react-native:0.32+' ?
Because I can't build using 0.33-rc.0 using your fork.

Thanks for the help :)

Exilz · 2016-08-26T10:34:17Z

I can confirm this works by using your fork, and changing the following :

removing compile 'com.airbnb.android:react-native-maps:0.7.1' from build.gradle (using only compile project(':react-native-maps'))

changing your fork's build.gradle dependency from com.facebook.react:react-native:0.32.0 to com.facebook.react:react-native:+

Once again, I might be doing it wrong, but it might help.

srenault · 2016-08-26T11:42:00Z

I successfully build my project by changing react-native version tocom.facebook.react:react-native:+, but now it throws me an error when my app starts:
Requiring unknown module "react".
@Exilz Do you have this error too ?

Exilz · 2016-08-26T11:45:06Z

No, did you properly change your package file to the fork? And then npm i again?
I also did a gradlew clean. That might help

chrisknepper · 2016-08-26T13:21:34Z

@Exilz Yes, it may be better to use + instead of 0.32.0 to refer to react-native from the plugin. I don't know very much about Gradle, but I do know that that dependency reference has been changed in this plugin several times.

I guess I was just worried about a situation where maybe a future version of react-native changes something if we're unspecific about the version we want, it could break things. But on the other hand, react-native development moves very fast (2 week release cycle), so it may be better to change it to +.

If you all want, I can make that change here.

Exilz · 2016-08-26T13:41:32Z

I guess that would be the best thing to do.
react-native-maps states that : "we are not officially going to support this module on anything but the latest version of React Native" anyway 😄

…(since react-native versions increment quickly)

chrisknepper · 2016-08-26T13:50:50Z

Done! As a side note, I'm having trouble getting my fork to install correctly on Android when using react-native link, but manual install works fine. I will try to update that today as well.

Exilz · 2016-08-26T13:52:38Z

Yeah I had to tweak the changes made by react-native link a bit, too.
I hope this gets merged soon 😄

srenault · 2016-08-26T21:44:37Z

this worked for me! thanks you too.

chrisknepper · 2016-08-27T02:13:33Z

So testing it just now, it react-native link actually seems to work just the same as manual linking 😄

The owners of this repo made a bunch of changes to the JS, so I'll need to update my PR...

chrisknepper · 2016-08-27T02:29:57Z

Okay, all resolved with the latest changes. It would be nice if the repo owners would consider merging this PR or at least acknowledging that there are people needing to use it on 0.32!

Until then, you can use my version which works by referencing react-native-maps in your project's package.json as such:

"react-native-maps": "chrisknepper/react-native-maps#3c9a6a7"

I'm glad this is helpful to people!

brentvatne · 2016-08-28T21:35:19Z

Awesome @chrisknepper! I just pinged @lelandrichardson about it and he said a co-worker who is working on maps will look at this shortly.

skellock · 2016-08-29T12:08:54Z

We've been trying to get a new release for a while.

For example #411 and I've got branches for RN 28, 29, and 30 to try to keep things up to date.

This repo has so much awesome in it but it's starting to age a bit.

@lelandrichardson have you considered PR this up to the React Native repo? It has a react-native-maps-shaped hole ready for this to plugin to.

If you need help, I'd be happy to assist in any way I can.

chrisknepper · 2016-08-29T13:30:54Z

@skellock Agreed, this should ultimately be pulled into RN core and replace the iOS-only MapView since it's cross-platform and better in every way :)

spikebrehm · 2016-08-29T18:20:42Z

I'll take a look at this today!

spikebrehm · 2016-08-29T18:22:26Z

android/gradle.properties

+GROUP=com.airbnb.android
+
+POM_DESCRIPTION=React Native Map view component for Android
+POM_URL=https://github.com/lelandrichardson/react-native-maps/tree/new-scv


These POM urls are 404ing. Does that matter? Should this point to a real URL?

I believe this doesnt matter much, it's only used by maven central, but since the lib will be pulled from node_modules, it's never used

@spikebrehm This code was moved to android/gradle.properties from android/lib/gradle.properties. I don't think that the file POM_URL points to ever existed, so it has always been 404ing, which you can see if you look at android/lib/gradle.properties in master.

I can update my PR to just remove this file entirely if you want, since it's optional.

felipecsl · 2016-08-29T18:24:22Z

looks good to me

felipecsl · 2016-08-29T21:37:00Z

android/build.gradle

+      mavenLocal()
+      jcenter()
+      maven {
+          url "$projectDir/../../react-native/android"


I believe this should be url "$projectDir/../node_modules/react-native/android", right? same on line 26

Actually no, my change is correct. In this case, $projectDir refers to <install location>/node_modules/react-native-maps/android, so $projectDir/../../react-native/android resolves to <install location>/node_modules/react-native/android

Putting url "$projectDir/../node_modules/react-native/android" resolves to <install location>/node_modules/react-native-maps/node_modules/react-native/android, a path which may not, and probably won't exist on end-user installs of this plugin. This is one of the things which causes Gradle to fetch the package from Maven, which isn't optimal.

spikebrehm · 2016-08-30T19:04:02Z

example/android/settings.gradle

@@ -1,2 +1,2 @@
-include ':app', ':react-native-maps'


This change caused building the example app to fail. Adding back ':app', fixed it. Once this is changed back, we can merge!

spikebrehm · 2016-08-30T19:05:25Z

Nevermind about this error:

npm WARN react-native-maps@0.8.0 requires a peer of react@>=15.3.0 but none was installed.
npm WARN react-native@0.32.0 requires a peer of react@~15.3.0 but none was installed.

That was from npm install in the root directory, not the example directory, which works fine. So confusing 🤦.

chrisknepper · 2016-08-30T20:34:54Z

Done :)

spikebrehm · 2016-08-30T20:48:47Z

Great, thanks for your contribution! @chrisknepper 🍻.

We can always use help maintaining the Android side of this project!

felipecsl · 2016-08-30T20:55:32Z

yay thanks @chrisknepper!

npomfret · 2016-08-31T19:17:00Z

So in summary, with RN 0.32, what do we need to do please?

charpeni · 2016-08-31T19:20:25Z

@npomfret Follow installation.md, everything works fine with the latest release (0.8.0) on RN 0.32.

chrisknepper · 2016-09-01T01:01:54Z

Thank you both @spikebrehm and @felipecsl and everyone in this thread for helping with this update 😀

I think this project is great work and I'm happy to be a part of it! IMO one of the most important aspects of this project is that it supports both platforms.

veedeo · 2016-09-01T15:40:33Z

After I upgraded my project to latest rn-maps Im getting this exception
am I missing something?

java.lang.NoSuchMethodError: No direct method (IJ)V in class Lcom/facebook/react/uimanager/events/Event; or its super classes (declaration of 'com.facebook.react.uimanager.events.Event' appears in /data/app/com.tandem-1/base.apk)
at com.airbnb.android.react.maps.RegionChangeEvent.(RegionChangeEvent.java:16)
at com.airbnb.android.react.maps.AirMapView$8.onCameraChange(AirMapView.java:220)
at com.google.android.gms.maps.GoogleMap$12.onCameraChange(Unknown Source)
at com.google.android.gms.maps.internal.zze$zza.onTransact(Unknown Source)
at android.os.Binder.transact(Binder.java:387)
at wd.a(:com.google.android.gms.DynamiteModulesB:93)
at maps.E.a.a(Unknown Source)
at maps.E.a$1.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

felipecsl · 2016-09-01T15:56:11Z

@veedeo you're most likely not using RN 0.32.0.
Can you double check what version you're on? You can see by running ./gradlew yourapp:dependencies

veedeo · 2016-09-01T17:45:08Z

Im on windows, but npm list returns
+-- react-native@0.32.0
+-- react-native-maps@0.8.0

what I did to upgrade, is manually changed versions in package.json and run npm install

felipecsl · 2016-09-01T17:48:54Z

you have to check what version of react native was resolved by gradle, since that's what is gonna be packaged into your apk. There is no guarantee that the one listed by npm is the right one, you have to run the gradle task I showed above in order to see it

charpeni · 2016-09-01T21:35:25Z

./gradlew clean maybe ?

The PR that added `AirMapModule` (#449) was merged after the PR that moved all the `lib/src/*` files to just `src/*` (#502). Fix it by moving `AirMapModule` to `src/`.

In #502, the local maven url pointing to the `react-native` node module changed to work better for the example app. However, that broke the path to `react-native` when developing in the context of the library, not the example app. In this PR, specify both paths.

In react-native-maps#502, the local maven url pointing to the `react-native` node module changed to work better for the example app. However, that broke the path to `react-native` when developing in the context of the library, not the example app. In this PR, specify both paths.

christopherdro · 2016-09-03T04:59:05Z

Awesome job with the new release!

Looks like a version bump was missed in one place. 😉
https://github.com/lelandrichardson/react-native-maps/blob/master/android/gradle.properties#L2

veedeo · 2016-09-03T06:31:36Z

@charpeni ./gradlew clean fixed the issue thanks
It feels like MapView loads much faster now, but unfortunatelly I still see the map overlapping issue

spikebrehm · 2016-09-06T18:21:19Z

Looks like a version bump was missed in one place.

🤦

#541

chrisknepper added 5 commits August 25, 2016 17:01

-Restructure plugin to allow for easier inclusion from source in reac…

6d68292

…t-native projects (for Android)

-Update requirements and structure in package.json

9e4a03b

-Consistent maven URLs

-Delete old lib files

e77765d

-Update installation documentation

b33de86

-Be unspecific about react-native dependency version in build.gradle …

17d9059

…(since react-native versions increment quickly)

chrisknepper added 2 commits August 26, 2016 22:19

Merge remote-tracking branch 'upstream/master'

f29e768

-Remove obsolete gradle file

3c9a6a7

chrisknepper mentioned this pull request Aug 28, 2016

Android crash when using 0.7.1 with React Native 0.32 #497

Closed

FuzzyTree mentioned this pull request Aug 29, 2016

RN 0.32 / Android - App crashes when rendering MapView #506

Closed

spikebrehm reviewed Aug 29, 2016
View reviewed changes

felipecsl reviewed Aug 29, 2016
View reviewed changes

spikebrehm reviewed Aug 30, 2016
View reviewed changes

-Fix missing include in android/settings.gradle

b38d6af

spikebrehm merged commit bc8084b into react-native-maps:master Aug 30, 2016

spikebrehm mentioned this pull request Aug 30, 2016

Update RegionChangeEvent to work with RN 0.32.0-rc #450

Closed

michalchudziak mentioned this pull request Aug 31, 2016

failed to find Build Tools revision 23.0.3 / [RN 0.32 maps 0.8.0] #513

Closed

npomfret mentioned this pull request Aug 31, 2016

0.8.0 crash android - NoSuchMethodError AirMapView$8.onCameraChange... #514

Closed

veedeo mentioned this pull request Sep 1, 2016

Android: first instance of the map overlaps everything when have another map in a different scene. #453

Closed

spikebrehm pushed a commit that referenced this pull request Sep 2, 2016

Fix path of AirMapModule

9ff97a5

The PR that added `AirMapModule` (#449) was merged after the PR that moved all the `lib/src/*` files to just `src/*` (#502). Fix it by moving `AirMapModule` to `src/`.

spikebrehm mentioned this pull request Sep 2, 2016

Fix path of AirMapModule #526

Merged

spikebrehm mentioned this pull request Sep 2, 2016

Fix path to react-native when developing outside of the example app #527

Merged

jamonholmgren mentioned this pull request Sep 8, 2016

Use latest version of RN to build Android #547

Merged

Update for compatibility with React-Native 0.32 (Android) and fix local installation/building and local React-Native reference #502

Update for compatibility with React-Native 0.32 (Android) and fix local installation/building and local React-Native reference #502

Conversation

chrisknepper commented Aug 26, 2016

srenault commented Aug 26, 2016

Exilz commented Aug 26, 2016

Exilz commented Aug 26, 2016

srenault commented Aug 26, 2016 • edited Loading

Exilz commented Aug 26, 2016

chrisknepper commented Aug 26, 2016

Exilz commented Aug 26, 2016 • edited Loading

chrisknepper commented Aug 26, 2016

Exilz commented Aug 26, 2016

srenault commented Aug 26, 2016

chrisknepper commented Aug 27, 2016

chrisknepper commented Aug 27, 2016 • edited Loading

brentvatne commented Aug 28, 2016

skellock commented Aug 29, 2016

chrisknepper commented Aug 29, 2016

spikebrehm commented Aug 29, 2016

spikebrehm Aug 29, 2016

Choose a reason for hiding this comment

felipecsl Aug 29, 2016

Choose a reason for hiding this comment

chrisknepper Aug 29, 2016

Choose a reason for hiding this comment

felipecsl commented Aug 29, 2016

felipecsl Aug 29, 2016

Choose a reason for hiding this comment

chrisknepper Aug 30, 2016

Choose a reason for hiding this comment

spikebrehm Aug 30, 2016

Choose a reason for hiding this comment

spikebrehm commented Aug 30, 2016

chrisknepper commented Aug 30, 2016

spikebrehm commented Aug 30, 2016

felipecsl commented Aug 30, 2016

npomfret commented Aug 31, 2016

charpeni commented Aug 31, 2016

chrisknepper commented Sep 1, 2016

veedeo commented Sep 1, 2016

felipecsl commented Sep 1, 2016

veedeo commented Sep 1, 2016

felipecsl commented Sep 1, 2016

charpeni commented Sep 1, 2016

christopherdro commented Sep 3, 2016

veedeo commented Sep 3, 2016

spikebrehm commented Sep 6, 2016

srenault commented Aug 26, 2016 •

edited

Loading

Exilz commented Aug 26, 2016 •

edited

Loading

chrisknepper commented Aug 27, 2016 •

edited

Loading