Remove unused NativeMethodsMixin for compat with RN 0.32
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unused `NativeMethodsMixin`, which is undefined in `react-native` 0.32.0, causing yellowbox warnings.
spikebrehm
pushed a commit
that referenced
this pull request
Sep 3, 2016
I removed `NativeMethodsMixin` in #511 because the module moved in 0.32.0, which made it throw errors. I assumed we didn't need it because none of its methods were being called, but I didn't realize that we want to include it to that consumers of the library can use those methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused
NativeMethodsMixin, which is undefined inreact-native0.32.0, causing yellowbox warnings.Related: #490
cc: @lelandrichardson