Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all remaining ESLint violations #515

Merged
merged 10 commits into from
Aug 31, 2016
Merged

Fix all remaining ESLint violations #515

merged 10 commits into from
Aug 31, 2016

Conversation

spikebrehm
Copy link

Fix all remaining ESLint violations. Commits split up mostly by which linting rule addressed.

$ npm run -s lint

Next step, after this: set up Travis to automatically run linting on PRs.

cc: @lelandrichardson @christopherdro @jrichardlai

@spikebrehm
Copy link
Author

I've also smoke-tested all the examples.

@jrichardlai
Copy link
Contributor

Wow thanks! looks good

@gilbox
Copy link
Contributor

gilbox commented Aug 31, 2016

lgtm

@jrichardlai
Copy link
Contributor

I got react-native-maps/example/examples/AnimatedViews.js 399:5 error Expected exception block, space or tab after '//' in comment spaced-comment

@spikebrehm
Copy link
Author

I got react-native-maps/example/examples/AnimatedViews.js 399:5 error Expected exception block, space or tab after '//' in comment spaced-comment

That's worrisome, because I don't see than locally on npm run lint, O_o.

In any case, I fixed that and pushed.

@spikebrehm spikebrehm merged commit b1ebd3a into master Aug 31, 2016
@spikebrehm spikebrehm deleted the more-eslint branch August 31, 2016 21:55
@jrichardlai
Copy link
Contributor

Strange, I'll double check if I have some settings set up somewhere

@spikebrehm
Copy link
Author

Just published 0.8.1 that includes this change.

@spikebrehm
Copy link
Author

It turns out 0.8.1 was faulty, because my working directory had an additional example app containing the react-native node module, which got published as part of the NPM package (:facepalm:), causing a @providesModule error, so I've unpublished it and published 0.8.2. Use that instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants